Source/core/rendering/RenderText.h - Issue 535633002: Common invalidateTreeIfNeeded()

Side by Side Diff: Source/core/rendering/RenderText.h

Issue 535633002: Common invalidateTreeIfNeeded() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address Dan's comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/rendering/RenderObject.cpp ('K') | « Source/core/rendering/RenderObject.cpp ('k') | Source/core/rendering/svg/RenderSVGModelObject.h » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * (C) 1999 Lars Knoll (knoll@kde.org)	2 * (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 2000 Dirk Mueller (mueller@kde.org)	3 * (C) 2000 Dirk Mueller (mueller@kde.org)

4 * Copyright (C) 2004-2009, 2013 Apple Inc. All rights reserved.	4 * Copyright (C) 2004-2009, 2013 Apple Inc. All rights reserved.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 166 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
177	177

178 void deleteTextBoxes();	178 void deleteTextBoxes();

179 bool containsOnlyWhitespace(unsigned from, unsigned len) const;	179 bool containsOnlyWhitespace(unsigned from, unsigned len) const;

180 float widthFromCache(const Font&, int start, int len, float xPos, TextDirect ion, HashSet<const SimpleFontData> fallbackFonts, GlyphOverflow*) const;	180 float widthFromCache(const Font&, int start, int len, float xPos, TextDirect ion, HashSet<const SimpleFontData> fallbackFonts, GlyphOverflow*) const;

181 bool isAllASCII() const { return m_isAllASCII; }	181 bool isAllASCII() const { return m_isAllASCII; }

182	182

183 void secureText(UChar mask);	183 void secureText(UChar mask);

184	184

185 bool isText() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.	185 bool isText() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.

186	186

	187 // FIXME: This is temporarily empty. Will let it actually work in following steps.
	Julien - ping for review 2014/09/04 19:48:04 Is that related to the work around folding RenderT Is that related to the work around folding RenderText invalidations into repaint-after-compositing-updates? If that's the case, we should just mention it along with the bug.
	188 virtual InvalidationReason invalidatePaintIfNeeded(const PaintInvalidationSt ate&, const RenderLayerModelObject&) OVERRIDE FINAL { return InvalidationNone; }

	189

187 // We put the bitfield first to minimize padding on 64-bit.	190 // We put the bitfield first to minimize padding on 64-bit.

188 bool m_hasBreakableChar : 1; // Whether or not we can be broken into multipl e lines.	191 bool m_hasBreakableChar : 1; // Whether or not we can be broken into multipl e lines.

189 bool m_hasBreak : 1; // Whether or not we have a hard break (e.g., <pre> wit h '\n').	192 bool m_hasBreak : 1; // Whether or not we have a hard break (e.g., <pre> wit h '\n').

190 bool m_hasTab : 1; // Whether or not we have a variable width tab character (e.g., <pre> with '\t').	193 bool m_hasTab : 1; // Whether or not we have a variable width tab character (e.g., <pre> with '\t').

191 bool m_hasBreakableStart : 1;	194 bool m_hasBreakableStart : 1;

192 bool m_hasBreakableEnd : 1;	195 bool m_hasBreakableEnd : 1;

193 bool m_hasEndWhiteSpace : 1;	196 bool m_hasEndWhiteSpace : 1;

194 bool m_linesDirty : 1; // This bit indicates that the text run has already d irtied specific	197 bool m_linesDirty : 1; // This bit indicates that the text run has already d irtied specific

195 // line boxes, and this hint will enable layoutInline Children to avoid	198 // line boxes, and this hint will enable layoutInline Children to avoid

196 // just dirtying everything when character data is mo dified (e.g., appended/inserted	199 // just dirtying everything when character data is mo dified (e.g., appended/inserted

(...skipping 39 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
236 inline RenderText* Text::renderer() const	239 inline RenderText* Text::renderer() const

237 {	240 {

238 return toRenderText(CharacterData::renderer());	241 return toRenderText(CharacterData::renderer());

239 }	242 }

240	243

241 void applyTextTransform(const RenderStyle*, String&, UChar);	244 void applyTextTransform(const RenderStyle*, String&, UChar);

242	245

243 } // namespace blink	246 } // namespace blink

244	247

245 #endif // RenderText_h	248 #endif // RenderText_h

OLD	NEW