Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: Source/core/rendering/svg/RenderSVGModelObject.cpp

Issue 535633002: Common invalidateTreeIfNeeded() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove the ASSERT Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/svg/RenderSVGModelObject.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2009, Google Inc. All rights reserved. 2 * Copyright (c) 2009, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 return false; 118 return false;
119 } 119 }
120 120
121 // The SVG addFocusRingRects() method adds rects in local coordinates so the def ault absoluteFocusRingQuads 121 // The SVG addFocusRingRects() method adds rects in local coordinates so the def ault absoluteFocusRingQuads
122 // returns incorrect values for SVG objects. Overriding this method provides acc ess to the absolute bounds. 122 // returns incorrect values for SVG objects. Overriding this method provides acc ess to the absolute bounds.
123 void RenderSVGModelObject::absoluteFocusRingQuads(Vector<FloatQuad>& quads) 123 void RenderSVGModelObject::absoluteFocusRingQuads(Vector<FloatQuad>& quads)
124 { 124 {
125 quads.append(localToAbsoluteQuad(FloatQuad(paintInvalidationRectInLocalCoord inates()))); 125 quads.append(localToAbsoluteQuad(FloatQuad(paintInvalidationRectInLocalCoord inates())));
126 } 126 }
127 127
128 void RenderSVGModelObject::invalidateTreeIfNeeded(const PaintInvalidationState& paintInvalidationState) 128 InvalidationReason RenderSVGModelObject::invalidatePaintIfNeeded(const PaintInva lidationState& paintInvalidationState, const RenderLayerModelObject& paintInvali dationContainer)
129 {
130 // Note: This is a reduced version of RenderBox::invalidateTreeIfNeeded().
131 // FIXME: Should share code with RenderBox::invalidateTreeIfNeeded().
132 ASSERT(!needsLayout());
133
134 if (!shouldCheckForPaintInvalidation(paintInvalidationState))
135 return;
136
137 invalidatePaintIfNeeded(paintInvalidationState);
138
139 RenderObject::invalidateTreeIfNeeded(paintInvalidationState);
140 }
141
142 void RenderSVGModelObject::invalidatePaintIfNeeded(const PaintInvalidationState& paintInvalidationState)
143 { 129 {
144 ForceHorriblySlowRectMapping slowRectMapping(&paintInvalidationState); 130 ForceHorriblySlowRectMapping slowRectMapping(&paintInvalidationState);
145 131
146 const LayoutRect oldPaintInvalidationRect = previousPaintInvalidationRect(); 132 return RenderObject::invalidatePaintIfNeeded(paintInvalidationState, paintIn validationContainer);
147 const LayoutPoint oldPositionFromPaintInvalidationContainer = previousPositi onFromPaintInvalidationContainer();
148 ASSERT(paintInvalidationState.paintInvalidationContainer() == containerForPa intInvalidation());
149 setPreviousPaintInvalidationRect(boundsRectForPaintInvalidation(&paintInvali dationState.paintInvalidationContainer(), &paintInvalidationState));
150 setPreviousPositionFromPaintInvalidationContainer(RenderLayer::positionFromP aintInvalidationContainer(this, &paintInvalidationState.paintInvalidationContain er(), &paintInvalidationState));
151
152 // If we are set to do a full paint invalidation that means the RenderView w ill be
153 // issue paint invalidations. We can then skip issuing of paint invalidation s for the child
154 // renderers as they'll be covered by the RenderView.
155 if (view()->doingFullPaintInvalidation())
156 return;
157
158 RenderObject::invalidatePaintIfNeeded(paintInvalidationState.paintInvalidati onContainer(), oldPaintInvalidationRect, oldPositionFromPaintInvalidationContain er, paintInvalidationState);
159 } 133 }
160 134
161 } // namespace blink 135 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/RenderSVGModelObject.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698