Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1438)

Issue 535623002: Subzero: Rename -external to -externalize to match llc. (Closed)

Created:
6 years, 3 months ago by Jim Stichnoth
Modified:
6 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Rename -external to -externalize to match llc. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=94539ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/llvm2ice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
6 years, 3 months ago (2014-09-02 21:55:39 UTC) #2
jvoung (off chromium)
lgtm
6 years, 3 months ago (2014-09-02 22:11:24 UTC) #3
Jim Stichnoth
6 years, 3 months ago (2014-09-02 22:13:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 94539ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698