Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 5356006: Seed the random number generator in Windows with rand_s... (Closed)

Created:
10 years, 1 month ago by jschuh
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Seed the random number generator in Windows with rand_s This is a quick fix for m9. It works on Windows Chrome because the random device is already initialized before permissions are dropped for the Chrome sandbox. The same trick isn't possible on Linux or Mac. I think the long-term solution is to provide an interface for supplying v8 with a true random number generator. Then Chrome can just hook up the generator from base/rand_util.h BUG=http://code.google.com/p/v8/issues/detail?id=936 TEST=None. Comitted as bleeding_edge r5889.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/platform-win32.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jschuh
This is a quick change to improve the random seed on Windows before freeze for ...
10 years, 1 month ago (2010-11-24 23:24:35 UTC) #1
Mads Ager (chromium)
10 years, 1 month ago (2010-11-25 07:26:45 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698