Add the base class for decoder buffers used in cast media.

Add the base class for decoder buffers used in cast media.

Creates a decoder buffer base class that exposes only the properties
of a decoder buffer. This makes it possible to hide how a buffer
is created and how it is organized in memory, this is left
as an implementation detail of derived classes.

BUG=408189
Committed: https://crrev.com/c434502c71349dc459aeedf76674897b0af0dc3e
Cr-Commit-Position: refs/heads/master@{#293298}

[damienv1, 2014-09-02 20:12:04]

damienv@chromium.org changed reviewers:
+ gunsch@chromium.org, lcwu@chromium.org, scherkus@chromium.org,
xhwang@chromium.org

[damienv1, 2014-09-02 22:15:21]

Please take a look. Thanks !

[lcwu1, 2014-09-03 05:51:21]

lgtm

[xhwang, 2014-09-03 17:13:49]

lgtm % nit

https://codereview.chromium.org/535563002/diff/1/chromecast/media/cma/base/de...
File chromecast/media/cma/base/decoder_buffer_wrapper.h (right):

https://codereview.chromium.org/535563002/diff/1/chromecast/media/cma/base/de...
chromecast/media/cma/base/decoder_buffer_wrapper.h:19: class
DecoderBufferWrapper : public DecoderBufferBase {
Add documentation about what this wrapper actually does. e.g. wraps a
media::DecoderBuffer into DecoderBufferBase...

BTW, this looks more like an Adapter than a Wrapper...

[damienv1, 2014-09-03 21:01:58]

https://codereview.chromium.org/535563002/diff/1/chromecast/media/cma/base/de...
File chromecast/media/cma/base/decoder_buffer_wrapper.h (right):

https://codereview.chromium.org/535563002/diff/1/chromecast/media/cma/base/de...
chromecast/media/cma/base/decoder_buffer_wrapper.h:19: class
DecoderBufferWrapper : public DecoderBufferBase {
On 2014/09/03 17:13:49, xhwang wrote:
> Add documentation about what this wrapper actually does. e.g. wraps a
> media::DecoderBuffer into DecoderBufferBase...
> 
> BTW, this looks more like an Adapter than a Wrapper...

Done.

[damienv1, 2014-09-03 21:36:17]

I plan to merge this CL this afternoon if no other comment.
Thanks for the review !

[damienv1, 2014-09-03 22:04:43]

The CQ bit was checked by damienv@chromium.org

[damienv1, 2014-09-03 22:05:24]

The CQ bit was unchecked by damienv@chromium.org

[damienv1, 2014-09-03 22:05:42]

The CQ bit was checked by damienv@chromium.org

[damienv1, 2014-09-03 23:18:31]

The CQ bit was unchecked by damienv@chromium.org

[damienv1, 2014-09-03 23:19:07]

The CQ bit was checked by damienv@chromium.org

[commit-bot: I haz the power, 2014-09-03 23:23:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/damienv@chromium.org/535563002/20001

[commit-bot: I haz the power, 2014-09-04 02:07:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 02:07:57]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[damienv1, 2014-09-04 14:26:50]

The CQ bit was checked by damienv@chromium.org

[commit-bot: I haz the power, 2014-09-04 14:27:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/damienv@chromium.org/535563002/20001

[commit-bot: I haz the power, 2014-09-04 14:54:30]

Committed patchset #2 (id:20001) as 6d1339a851cbf16097c1c8c8325e5cd5073499ba

[commit-bot: I haz the power, 2014-09-10 03:31:25]

Patchset 2 (id:??) landed as
https://crrev.com/c434502c71349dc459aeedf76674897b0af0dc3e
Cr-Commit-Position: refs/heads/master@{#293298}