Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 535553002: Only allocate a foreground layer for a CLM if there are composited negative-z-index-children. (Closed)

Created:
6 years, 3 months ago by chrishtr
Modified:
6 years, 3 months ago
Reviewers:
Ian Vollick
CC:
abarth-chromium, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Only allocate a foreground layer for a CLM if there are composited negative-z-index-children. Otherwise, those children can be rendered as pat of the software rendering of the current layer and its non-compositing descendants. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181424

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -29 lines) Patch
M LayoutTests/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt View 2 chunks +2 lines, -14 lines 0 comments Download
M LayoutTests/compositing/geometry/bounds-ignores-hidden-expected.txt View 1 chunk +1 line, -7 lines 0 comments Download
M LayoutTests/css3/compositing/mix-blend-mode-2nd-stacking-context-composited-expected.txt View 1 1 chunk +1 line, -7 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
chrishtr
I *think* this handles all cases, but could be wrong. The motivating example is from ...
6 years, 3 months ago (2014-09-02 19:57:40 UTC) #2
chrishtr
Ping?
6 years, 3 months ago (2014-09-04 16:57:00 UTC) #3
Ian Vollick
On 2014/09/04 16:57:00, chrishtr wrote: > Ping? I can't see a reason for the extra ...
6 years, 3 months ago (2014-09-04 17:00:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/535553002/1
6 years, 3 months ago (2014-09-04 17:02:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/23469)
6 years, 3 months ago (2014-09-04 18:09:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/535553002/20001
6 years, 3 months ago (2014-09-04 20:33:38 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 00:26:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181424

Powered by Google App Engine
This is Rietveld 408576698