Issue 535543002: Remove ShellPtrWatcher details from public header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 535543002: Remove ShellPtrWatcher details from public header (Closed)

Created:
6 years, 3 months ago by DaveMoore

Modified:
6 years, 3 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove ShellPtrWatcher details from public header BUG= Committed: https://crrev.com/a50ab4aed76d7c5baabf3e59127bb9d060b5e490 Cr-Commit-Position: refs/heads/master@{#293000}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -18 lines)			Patch
	M	mojo/public/cpp/application/application_impl.h	View		2 chunks	+2 lines, -10 lines	0 comments	Download
	M	mojo/public/cpp/application/lib/application_impl.cc	View		3 chunks	+17 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/535543002/1

6 years, 3 months ago (2014-09-02 19:54:57 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 7c8117f695f4f5c4694612429eda52df51f50ed8

6 years, 3 months ago (2014-09-02 21:24:50 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:20:57 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a50ab4aed76d7c5baabf3e59127bb9d060b5e490
Cr-Commit-Position: refs/heads/master@{#293000}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages