Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 53553003: WIP: Ash IME support (Closed)

Created:
7 years, 1 month ago by yukawa
Modified:
6 years, 10 months ago
Reviewers:
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, kalyank, ben+aura_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

WIP: Ash IME support This CL does following things. * Ports TSF (Text Services Framework) back-end from ui/base/ime/win to win8/metro_driver/ime/ This is necessary because TSF runtime can work well only when the target process is foreground process in terms of Win32 focus management. * Introduces new IPC messages between the browser process and the metro_driver process This is necessary because IME state must be synced between the browser process and the metro_driver process. Under review in https://codereview.chromium.org/74783010/ * Wires up the browser process and the metro_driver process with the new IPC messages for remote IME support == Things already committed == * Introduces a new ui::InputMethod implementation class named ui::RemoteInputMethodWin. This will be used as a proxy object that works as if it was the actual IME back-end running in the metro_driver process. https://codereview.chromium.org/67503004/ BUG=164964

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1533 lines, -277 lines) Patch
M ui/aura/remote_root_window_host_win.h View 4 chunks +23 lines, -1 line 0 comments Download
M ui/aura/remote_root_window_host_win.cc View 6 chunks +104 lines, -0 lines 0 comments Download
M ui/base/ime/input_method_factory.cc View 2 chunks +18 lines, -1 line 0 comments Download
A ui/metro_viewer/ime_types.h View 1 chunk +50 lines, -0 lines 0 comments Download
M ui/metro_viewer/metro_viewer.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/metro_viewer/metro_viewer_messages.h View 2 chunks +49 lines, -0 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.h View 5 chunks +44 lines, -1 line 0 comments Download
M win8/metro_driver/chrome_app_view_ash.cc View 9 chunks +117 lines, -1 line 0 comments Download
A win8/metro_driver/ime/ime.gypi View 1 chunk +23 lines, -0 lines 0 comments Download
A win8/metro_driver/ime/ime_popup_monitor.h View 1 chunk +22 lines, -0 lines 0 comments Download
A win8/metro_driver/ime/ime_popup_monitor.cc View 1 chunk +75 lines, -0 lines 0 comments Download
A win8/metro_driver/ime/ime_popup_observer.h View 1 chunk +22 lines, -0 lines 0 comments Download
A win8/metro_driver/ime/input_scope.h View 1 chunk +22 lines, -0 lines 0 comments Download
A win8/metro_driver/ime/input_scope.cc View 1 chunk +82 lines, -0 lines 0 comments Download
A win8/metro_driver/ime/keyevent_filter.h View 1 chunk +20 lines, -0 lines 0 comments Download
A win8/metro_driver/ime/keyevent_filter.cc View 1 chunk +80 lines, -0 lines 0 comments Download
A win8/metro_driver/ime/language_profile_monitor.h View 1 chunk +19 lines, -0 lines 0 comments Download
A win8/metro_driver/ime/language_profile_monitor.cc View 1 chunk +149 lines, -0 lines 0 comments Download
A win8/metro_driver/ime/language_profile_observer.h View 1 chunk +26 lines, -0 lines 0 comments Download
A win8/metro_driver/ime/text_service.h View 1 chunk +49 lines, -0 lines 0 comments Download
A win8/metro_driver/ime/text_service.cc View 1 chunk +252 lines, -0 lines 0 comments Download
A + win8/metro_driver/ime/text_store.h View 8 chunks +68 lines, -69 lines 0 comments Download
A + win8/metro_driver/ime/text_store.cc View 46 chunks +163 lines, -204 lines 0 comments Download
A win8/metro_driver/ime/text_store_delegate.h View 1 chunk +52 lines, -0 lines 0 comments Download
M win8/metro_driver/metro_driver.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698