Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 535463002: Remove runtime feature flag "WebAnimationsSVG" (Closed)

Created:
6 years, 3 months ago by kouhei (in TOK)
Modified:
6 years, 3 months ago
Reviewers:
tkent, dstockwell
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove runtime feature flag "WebAnimationsSVG" Depends on chromium CL: https://codereview.chromium.org/530353002/ The flag is not used anymore. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181353

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
kouhei (in TOK)
dstockwell: Hi, do you think we can remove the flag? or is it planned to ...
6 years, 3 months ago (2014-09-02 17:12:01 UTC) #2
dstockwell
lgtm, we can always add this back if needed. Is there a corresponding patch to ...
6 years, 3 months ago (2014-09-03 03:15:48 UTC) #3
kouhei (in TOK)
On 2014/09/03 03:15:48, dstockwell wrote: > lgtm, we can always add this back if needed. ...
6 years, 3 months ago (2014-09-03 03:19:41 UTC) #4
kouhei (in TOK)
tkent: Would you approve the change? Thanks.
6 years, 3 months ago (2014-09-03 03:20:50 UTC) #6
tkent
lgtm
6 years, 3 months ago (2014-09-03 03:21:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/535463002/1
6 years, 3 months ago (2014-09-03 03:21:47 UTC) #9
kouhei (in TOK)
On 2014/09/03 03:21:35, tkent wrote: > lgtm Thanks! I'll submit this once the chromium side ...
6 years, 3 months ago (2014-09-03 03:36:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/535463002/1
6 years, 3 months ago (2014-09-03 21:05:05 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 3 months ago (2014-09-03 22:15:54 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 23:26:42 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181353

Powered by Google App Engine
This is Rietveld 408576698