Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 535453002: [Android] Always request BeginFrame when touch received (Closed)

Created:
6 years, 3 months ago by jdduke (slow)
Modified:
6 years, 3 months ago
Reviewers:
no sievers
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Always request BeginFrame when touch received Android's vsync listener will now only dispatch a BeginFrame message if such was requested. This exposed a hole in our BeginFrame request pipeline, where short-circuited touch forwarding would bypass the vsync request. Instead, always request the BeginFrame if a touch event was received from the platform, potentially reducing the first frame's latency when the page lacks a touch handler. latency. BUG=408377 Committed: https://crrev.com/4f0ec3cf8a4817fa86b0bdbf77a519516f8945d8 Cr-Commit-Position: refs/heads/master@{#292992}

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 chunks +11 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jdduke (slow)
sievers@: PTAL, thanks.
6 years, 3 months ago (2014-09-02 18:02:49 UTC) #2
no sievers
lgtm
6 years, 3 months ago (2014-09-02 18:42:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/535453002/20001
6 years, 3 months ago (2014-09-02 18:49:32 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-09-02 19:59:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0ffe1034008144bf499282aa52dca87ac8fce2c1
6 years, 3 months ago (2014-09-02 20:41:19 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:20:36 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f0ec3cf8a4817fa86b0bdbf77a519516f8945d8
Cr-Commit-Position: refs/heads/master@{#292992}

Powered by Google App Engine
This is Rietveld 408576698