introduce DocumentParserClient to receive parser stopped notification

introduce DocumentParserClient to receive parser stopped notification

This depends on HTMLDocumentParser fix: https://codereview.chromium.org/532343002/

XMLHttpRequest and HTMLImport need callback when document has finished
parsing. This CL introduces an interface DocumentParserClient for receiving the
"parser stopped" notification, and migrates HTMLImportLoader to use the
interface.

BUG=409461
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181503

[kouhei (in TOK), 2014-09-03 22:36:20]

kouhei@chromium.org changed reviewers:
+ abarth@chromium.org, morrita@chromium.org

[kouhei (in TOK), 2014-09-03 22:38:12]

kouhei@chromium.org changed reviewers:
+ eseidel@chromium.org

[kouhei (in TOK), 2014-09-03 22:38:13]

Would you take a look? This is in preparation to make XHR use background parser,
without adding another hack in |Document::finishedParsing|

[kouhei (in TOK), 2014-09-03 22:39:00]

kouhei@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org

[kouhei (in TOK), 2014-09-03 22:40:41]

oilpan-reviews: Would you help me resolve the below compile error?

https://codereview.chromium.org/535403002/diff/1/Source/core/dom/DocumentPars...
File Source/core/dom/DocumentParser.cpp (right):

https://codereview.chromium.org/535403002/diff/1/Source/core/dom/DocumentPars...
Source/core/dom/DocumentParser.cpp:58: // visitor->trace(m_clients);
This gives me an error, but I don't know how to resolve this:

../../third_party/WebKit/Source/platform/heap/Visitor.h:297:33: error: cannot
initialize a parameter of type 'typename DefaultAllocator::Visitor *' (aka
'WTF::DefaultAllocatorDummyVisitor *') with an rvalue of type 'blink::Visitor *'
        const_cast<T&>(t).trace(this);
                                ^~~~
../../third_party/WebKit/Source/core/dom/DocumentParser.cpp:57:14: note: in
instantiation of function template specialization
'blink::Visitor::trace<WTF::HashSet<WTF::RawPtr<blink::DocumentParserClient>,
WTF::PtrHash<WTF::RawPtr<blink::DocumentParserClient> >,
WTF::HashTraits<WTF::RawPtr<blink::DocumentParserClient> >,
WTF::DefaultAllocator> >' requested here
    visitor->trace(m_clients);
             ^
../../third_party/WebKit/Source/wtf/HashSet.h:111:49: note: passing argument to
parameter 'visitor' here
        void trace(typename Allocator::Visitor* visitor) {
m_impl.trace(visitor); }

[haraken, 2014-09-04 00:56:46]

On 2014/09/03 22:40:41, kouhei wrote:
> oilpan-reviews: Would you help me resolve the below compile error?
> 
>
https://codereview.chromium.org/535403002/diff/1/Source/core/dom/DocumentPars...
> File Source/core/dom/DocumentParser.cpp (right):
> 
>
https://codereview.chromium.org/535403002/diff/1/Source/core/dom/DocumentPars...
> Source/core/dom/DocumentParser.cpp:58: // visitor->trace(m_clients);
> This gives me an error, but I don't know how to resolve this:
> 
> ../../third_party/WebKit/Source/platform/heap/Visitor.h:297:33: error: cannot
> initialize a parameter of type 'typename DefaultAllocator::Visitor *' (aka
> 'WTF::DefaultAllocatorDummyVisitor *') with an rvalue of type 'blink::Visitor
*'
>         const_cast<T&>(t).trace(this);
>                                 ^~~~
> ../../third_party/WebKit/Source/core/dom/DocumentParser.cpp:57:14: note: in
> instantiation of function template specialization
> 'blink::Visitor::trace<WTF::HashSet<WTF::RawPtr<blink::DocumentParserClient>,
> WTF::PtrHash<WTF::RawPtr<blink::DocumentParserClient> >,
> WTF::HashTraits<WTF::RawPtr<blink::DocumentParserClient> >,
> WTF::DefaultAllocator> >' requested here
>     visitor->trace(m_clients);
>              ^
> ../../third_party/WebKit/Source/wtf/HashSet.h:111:49: note: passing argument
to
> parameter 'visitor' here
>         void trace(typename Allocator::Visitor* visitor) {
> m_impl.trace(visitor); }

You'll need to add an empty trace method in DocumentParserClient.

[eseidel, 2014-09-04 06:42:31]

This makes a ton of sense.  But I don't think that the parser wants to keep its
clients alive.  The client should be responsible for removign itself from the
parser when it dies, and the parse rshould just keep a raw ptr to the client,
no?

[kouhei (in TOK), 2014-09-04 21:08:01]

Thanks for your comments!

On 2014/09/04 06:42:31, eseidel wrote:
> This makes a ton of sense.  But I don't think that the parser wants to keep
its
> clients alive.  The client should be responsible for removign itself from the
> parser when it dies, and the parse rshould just keep a raw ptr to the client,
> no?

Done, changed to weak set.

https://codereview.chromium.org/535403002/diff/1/Source/core/dom/DocumentPars...
File Source/core/dom/DocumentParser.cpp (right):

https://codereview.chromium.org/535403002/diff/1/Source/core/dom/DocumentPars...
Source/core/dom/DocumentParser.cpp:58: // visitor->trace(m_clients);
On 2014/09/03 22:40:41, kouhei wrote:
> This gives me an error, but I don't know how to resolve this:
> 
> ../../third_party/WebKit/Source/platform/heap/Visitor.h:297:33: error: cannot
> initialize a parameter of type 'typename DefaultAllocator::Visitor *' (aka
> 'WTF::DefaultAllocatorDummyVisitor *') with an rvalue of type 'blink::Visitor
*'
>         const_cast<T&>(t).trace(this);
>                                 ^~~~
> ../../third_party/WebKit/Source/core/dom/DocumentParser.cpp:57:14: note: in
> instantiation of function template specialization
> 'blink::Visitor::trace<WTF::HashSet<WTF::RawPtr<blink::DocumentParserClient>,
> WTF::PtrHash<WTF::RawPtr<blink::DocumentParserClient> >,
> WTF::HashTraits<WTF::RawPtr<blink::DocumentParserClient> >,
> WTF::DefaultAllocator> >' requested here
>     visitor->trace(m_clients);
>              ^
> ../../third_party/WebKit/Source/wtf/HashSet.h:111:49: note: passing argument
to
> parameter 'visitor' here
>         void trace(typename Allocator::Visitor* visitor) {
> m_impl.trace(visitor); }

Resolved. We needed a #if ENABLE(OILPAN) here, as the m_clients were
WillBeGCMixin.

[kouhei (in TOK), 2014-09-05 21:15:01]

eseidel: Would you take a look again?

[eseidel, 2014-09-05 21:39:48]

The CQ bit was checked by eseidel@chromium.org

[eseidel, 2014-09-05 21:39:49]

lgtm

[kouhei (in TOK), 2014-09-05 21:40:09]

Thanks!

[commit-bot: I haz the power, 2014-09-05 21:41:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kouhei@chromium.org/535403002/40001

[commit-bot: I haz the power, 2014-09-05 23:41:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 23:41:36]

Exceeded time limit waiting for builds to trigger.

[kouhei (in TOK), 2014-09-06 20:27:49]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-09-06 20:29:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kouhei@chromium.org/535403002/40001

[commit-bot: I haz the power, 2014-09-07 08:14:44]

Committed patchset #3 (id:40001) as 181503