Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Issue 535393002: Clear GCMProfileService::account_id_ when signing out (Closed)

Created:
6 years, 3 months ago by jianli
Modified:
6 years, 3 months ago
Reviewers:
fgorski
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clear GCMProfileService::account_id_ in when signing out This fixed the bug that signing out and then signing in again does not restart GCM. BUG=393043 TEST=new test added Committed: https://crrev.com/2f90d82bfba66c4b0f98ccb2ecfbb6ec2961b8c9 Cr-Commit-Position: refs/heads/master@{#293319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/browser/services/gcm/gcm_profile_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service_unittest.cc View 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jianli
6 years, 3 months ago (2014-09-03 21:42:20 UTC) #2
fgorski
lgtm
6 years, 3 months ago (2014-09-03 22:36:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/535393002/1
6 years, 3 months ago (2014-09-03 23:23:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1885)
6 years, 3 months ago (2014-09-04 01:59:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/535393002/1
6 years, 3 months ago (2014-09-04 17:10:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8b1970b93f0f7ccbd05e868ded1944d7199c7c7c
6 years, 3 months ago (2014-09-04 17:53:16 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:32:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f90d82bfba66c4b0f98ccb2ecfbb6ec2961b8c9
Cr-Commit-Position: refs/heads/master@{#293319}

Powered by Google App Engine
This is Rietveld 408576698