Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 535373002: Move extension/app default icon into src/extensions (Closed)

Created:
6 years, 3 months ago by Jun Mukai
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou, Yaron, oshima, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, Yaron, Peter Kasting, gone
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move extension/app default icon into src/extensions BUG=407777 R=yoz@chromium.org, oshima@chromium.org, sky@chromium.org TEST=manually Committed: https://crrev.com/4245dfe8b5f0f73c96b3cd25547b9e9b570f4221 Cr-Commit-Position: refs/heads/master@{#293549}

Patch Set 1 #

Patch Set 2 : icon_image #

Total comments: 2

Patch Set 3 : fix typo #

Patch Set 4 : rebase #

Patch Set 5 : fix gn compile error #

Patch Set 6 : theme_resource file #

Patch Set 7 : icon path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -17 lines) Patch
M athena/content/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M athena/content/content_app_model_builder.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M athena/resources/athena_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/app/theme/default_100_percent/common/app_default_icon.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/extension_default_icon.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/app_default_icon.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/extension_default_icon.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 3 4 5 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/background/background_contents_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/apps/chrome_app_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_repack_chrome_100_percent.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/chrome_repack_chrome_200_percent.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/BUILD.gn View 1 2 2 chunks +16 lines, -1 line 0 comments Download
M extensions/browser/extension_icon_image.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
A extensions/browser/resources/extensions_browser_resources.grd View 1 chunk +18 lines, -0 lines 0 comments Download
M extensions/extensions_resources.gyp View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 24 (7 generated)
Jun Mukai
6 years, 3 months ago (2014-09-03 20:59:36 UTC) #1
Jun Mukai
Removed an ifdef in extension_icon_image which was introduced simply because of the hack in content_app_model_builder.cc
6 years, 3 months ago (2014-09-03 22:06:06 UTC) #2
oshima
lgtm
6 years, 3 months ago (2014-09-03 22:22:28 UTC) #3
Jun Mukai
+sky for approval of mechanical change in chrome/ I also wait for the review from ...
6 years, 3 months ago (2014-09-03 22:25:17 UTC) #5
sky
LGTM
6 years, 3 months ago (2014-09-03 23:33:18 UTC) #6
Jun Mukai
yoz, can you take a look?
6 years, 3 months ago (2014-09-04 17:42:29 UTC) #7
Yoyo Zhou
LGTM https://chromiumcodereview.appspot.com/535373002/diff/20001/extensions/BUILD.gn File extensions/BUILD.gn (right): https://chromiumcodereview.appspot.com/535373002/diff/20001/extensions/BUILD.gn#newcode28 extensions/BUILD.gn:28: # (exntensions_browser_resources action) typo: extensions
6 years, 3 months ago (2014-09-04 19:45:38 UTC) #8
Jun Mukai
https://chromiumcodereview.appspot.com/535373002/diff/20001/extensions/BUILD.gn File extensions/BUILD.gn (right): https://chromiumcodereview.appspot.com/535373002/diff/20001/extensions/BUILD.gn#newcode28 extensions/BUILD.gn:28: # (exntensions_browser_resources action) On 2014/09/04 19:45:38, Yoyo Zhou wrote: ...
6 years, 3 months ago (2014-09-04 19:51:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/535373002/60001
6 years, 3 months ago (2014-09-04 22:36:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/2540) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2335) linux_chromium_gn_rel ...
6 years, 3 months ago (2014-09-05 00:34:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/535373002/80001
6 years, 3 months ago (2014-09-05 01:46:43 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/2558) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2354) android_dbg_tests_recipe ...
6 years, 3 months ago (2014-09-05 03:27:13 UTC) #17
Jun Mukai
+pkasting, yfriedman The android failure is really strange. IDR_INFOBAR_PROTECTED_MEDIA_IDENTIFIER, which is used android only, also ...
6 years, 3 months ago (2014-09-05 07:17:56 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/535373002/120001
6 years, 3 months ago (2014-09-05 16:38:20 UTC) #20
Yaron
I think it's fine. +dfalcantara who would know for sure
6 years, 3 months ago (2014-09-05 16:57:27 UTC) #22
commit-bot: I haz the power
Committed patchset #7 (id:120001) as d2aaffd817e59261e9b2edf09cfc3704c604a219
6 years, 3 months ago (2014-09-05 17:42:16 UTC) #23
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:40:32 UTC) #24
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/4245dfe8b5f0f73c96b3cd25547b9e9b570f4221
Cr-Commit-Position: refs/heads/master@{#293549}

Powered by Google App Engine
This is Rietveld 408576698