Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 535363002: fast/block/float/015.html uses wrong urls for resources (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
Reviewers:
eae, ojan
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

fast/block/float/015.html uses wrong urls for resources Fix the urls used in the testcase and mark the TextExpectations to rebaseline non linux platforms. BUG=410491 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181419

Patch Set 1 #

Patch Set 2 : Copy resources #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/block/float/015.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/block/float/resources/base.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/block/float/resources/vblank.gif View 1 Binary file 0 comments Download
M LayoutTests/platform/linux/fast/block/float/015-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/linux/fast/block/float/015-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
6 years, 3 months ago (2014-09-03 21:19:01 UTC) #2
ojan
Can we copy the resources into the fast/block/float/resources directory? I'd like to get to a ...
6 years, 3 months ago (2014-09-04 20:02:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/535363002/20001
6 years, 3 months ago (2014-09-04 21:31:43 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-04 23:31:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181419

Powered by Google App Engine
This is Rietveld 408576698