Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 535343003: Add test case for unloading Easy Unlock app when system suspends. (Closed)

Created:
6 years, 3 months ago by Tim Song
Modified:
6 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add test case for unloading Easy Unlock app when system suspends. BUG=410082 Committed: https://crrev.com/66668ed3279d663b94d6bd18e76035b373270eda Cr-Commit-Position: refs/heads/master@{#295624}

Patch Set 1 #

Total comments: 2

Patch Set 2 : move ifdef out #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc View 1 5 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Tim Song
6 years, 3 months ago (2014-09-03 21:29:24 UTC) #2
xiyuan
lgtm https://codereview.chromium.org/535343003/diff/1/chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc File chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc (right): https://codereview.chromium.org/535343003/diff/1/chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc#newcode148 chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc:148: #if defined(GOOGLE_CHROME_BUILD) nit: The test is essentially empty ...
6 years, 3 months ago (2014-09-03 21:36:13 UTC) #3
Tim Song
Forgot about this CL. https://codereview.chromium.org/535343003/diff/1/chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc File chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc (right): https://codereview.chromium.org/535343003/diff/1/chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc#newcode148 chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc:148: #if defined(GOOGLE_CHROME_BUILD) On 2014/09/03 21:36:13, ...
6 years, 3 months ago (2014-09-18 23:50:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/535343003/20001
6 years, 3 months ago (2014-09-18 23:51:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 48e65ad28c9bbaae9534a5d485497aabb364a07f
6 years, 3 months ago (2014-09-19 00:34:22 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 00:35:07 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66668ed3279d663b94d6bd18e76035b373270eda
Cr-Commit-Position: refs/heads/master@{#295624}

Powered by Google App Engine
This is Rietveld 408576698