Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 535333002: Mojo: Make the mojom bindings generator not exponential in the import depth. (Closed)

Created:
6 years, 3 months ago by viettrungluu
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/d8988a18cf52f4cfc146a5a57251bfa6cd4ef8f6 Cr-Commit-Position: refs/heads/master@{#293352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M mojo/public/tools/bindings/pylib/mojom/generate/data.py View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
viettrungluu
6 years, 3 months ago (2014-09-03 19:35:53 UTC) #1
jamesr
lgtm
6 years, 3 months ago (2014-09-03 19:37:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/535333002/1
6 years, 3 months ago (2014-09-03 19:41:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-03 20:32:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/8559)
6 years, 3 months ago (2014-09-04 02:26:56 UTC) #7
viettrungluu
Committed patchset #1 (id:1) to pending queue manually as 14c4929 (presubmit successful).
6 years, 3 months ago (2014-09-04 22:10:47 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:33:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8988a18cf52f4cfc146a5a57251bfa6cd4ef8f6
Cr-Commit-Position: refs/heads/master@{#293352}

Powered by Google App Engine
This is Rietveld 408576698