Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 53533004: [webcrypto] Remove the TODO for NullKey(). (Closed)

Created:
7 years, 1 month ago by eroman
Modified:
7 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[webcrypto] Remove the TODO for NullKey(). BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232917

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M content/renderer/webcrypto/webcrypto_impl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/webcrypto/webcrypto_impl.cc View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl_unittest.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eroman
(Depends on Blink roll which has not yet happened)
7 years, 1 month ago (2013-10-31 01:28:47 UTC) #1
eroman
Blink roll has happened, so this should compile now.
7 years, 1 month ago (2013-10-31 20:32:00 UTC) #2
Ryan Sleevi
lgtm
7 years, 1 month ago (2013-11-02 00:07:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/53533004/160001
7 years, 1 month ago (2013-11-04 20:29:17 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-04 21:15:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/53533004/160001
7 years, 1 month ago (2013-11-04 21:51:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/53533004/160001
7 years, 1 month ago (2013-11-05 03:11:46 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 05:32:34 UTC) #8
Message was sent while issue was closed.
Change committed as 232917

Powered by Google App Engine
This is Rietveld 408576698