Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 535313002: Indicate user gesture for mouse down/up while pointer locked. (Closed)

Created:
6 years, 3 months ago by scheib
Modified:
6 years, 3 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Indicate user gesture for mouse down/up while pointer locked. Previously all mouse down/up events failed to signal a user gesture, causing errors when attempting to use an API such as Fullscreen that require a user gesture. BUG=403077 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
A + LayoutTests/pointer-lock/pointerlock-then-fullscreen.html View 2 chunks +10 lines, -5 lines 0 comments Download
A + LayoutTests/pointer-lock/pointerlock-then-fullscreen-expected.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scheib
jochen, PTAL, as you recently did user gesture work in this area.
6 years, 3 months ago (2014-09-03 19:24:20 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-04 09:47:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/535313002/1
6 years, 3 months ago (2014-09-04 15:53:21 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-04 15:58:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181373

Powered by Google App Engine
This is Rietveld 408576698