Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 535283006: Add missing -Wno-missing-field-initializer flag to standalone.gypi. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
CC:
tfarina, v8-dev
Project:
v8
Visibility:
Public.

Description

Add missing -Wno-missing-field-initializer flag to standalone.gypi. Chrome uses -Wno-missing-field-initializers when building V8, so we should better use that as well. It silences warnings generated for the GTest port files. BUG=v8:3518 LOG=n R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M build/standalone.gypi View 3 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
Jochen: PTAL Thiago: FYI
6 years, 3 months ago (2014-09-04 04:40:10 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-04 09:23:28 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as 23676 (presubmit successful).
6 years, 3 months ago (2014-09-04 09:23:59 UTC) #4
tfarina
6 years, 3 months ago (2014-09-04 18:23:50 UTC) #6
Message was sent while issue was closed.
lgtm (rubber-stamp).

Powered by Google App Engine
This is Rietveld 408576698