Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 535283004: Revert of Add test for ChromeVox keyboard commands. (Closed)

Created:
6 years, 3 months ago by Vadim Sh.
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni, David Tseng, sky
CC:
chromium-reviews, ben+aura_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank, sadrul, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Add test for ChromeVox keyboard commands. (patchset #7 id:120001 of https://codereview.chromium.org/490443002/) Reason for revert: Broke interactive_ui_tests on Linux ChromiumOS Ozone: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%282%29/builds/1626/steps/interactive_ui_tests Failing tests: ChromeVoxNavigateAndSelect_0 ChromeVoxPrefixKey_0 ChromeVoxPrefixKey_1 ChromeVoxShiftSearch_0 ChromeVoxShiftSearch_1 Original issue's description: > Add test for ChromeVox keyboard commands. > > This is just a couple of quick sanity checks to prevent future regressions > like the one in the linked bug. It tests both a Search+Shift shortcut and > the corresponding Prefix Key shortcut. > > Adds support for sending the meta modifier key in > aura/x11 tests. > > BUG=404470 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547 > > Committed: https://chromium.googlesource.com/chromium/src/+/8cab2737f1cb6e6011b0946f6bef5027868602c0 TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org NOTREECHECKS=true NOTRY=true BUG=404470 Committed: https://crrev.com/14b630c415923f86f1cdf44f600aa4539a7d4737 Cr-Commit-Position: refs/heads/master@{#293251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -119 lines) Patch
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 2 chunks +5 lines, -105 lines 0 comments Download
M ui/aura/test/ui_controls_factory_aurax11.cc View 4 chunks +2 lines, -4 lines 0 comments Download
M ui/aura/test/ui_controls_factory_ozone.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vadim Sh.
Created Revert of Add test for ChromeVox keyboard commands.
6 years, 3 months ago (2014-09-04 02:00:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimsh@chromium.org/535283004/1
6 years, 3 months ago (2014-09-04 02:02:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7abcef110322f09ab569000497df3d61c47e1607
6 years, 3 months ago (2014-09-04 02:04:22 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:29:31 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14b630c415923f86f1cdf44f600aa4539a7d4737
Cr-Commit-Position: refs/heads/master@{#293251}

Powered by Google App Engine
This is Rietveld 408576698