Add WebDocument::manifestURL().

Add WebDocument::manifestURL().

BUG=410419
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181624

[mlamouri (slow - plz ping), 2014-09-03 18:59:43]

mlamouri@chromium.org changed reviewers:
+ abarth@chromium.org

[mlamouri (slow - plz ping), 2014-09-03 19:07:31]

This is used in a WIP CL:
https://code.google.com/p/chromium/issues/detail?id=409996

[mlamouri (slow - plz ping), 2014-09-03 19:08:00]

On 2014/09/03 19:07:31, Mounir Lamouri wrote:
> This is used in a WIP CL:
> https://code.google.com/p/chromium/issues/detail?id=409996

https://codereview.chromium.org/537053002/

[mlamouri (slow - plz ping), 2014-09-08 10:06:31]

mlamouri@chromium.org changed reviewers:
+ jochen@chromium.org

[kenneth.r.christiansen, 2014-09-08 10:09:15]

kenneth.r.christiansen@intel.com changed reviewers:
+ kenneth.r.christiansen@intel.com

[kenneth.r.christiansen, 2014-09-08 10:09:15]

core parts lgtm

[jochen (gone - plz use gerrit), 2014-09-08 11:08:11]

as discussed via email, I think the entire manifest feature should be implement
in content

we don't have special support for other <link> elements not used by blink
either. so not lgtm

[mlamouri (slow - plz ping), 2014-09-08 11:23:28]

On 2014/09/08 11:08:11, jochen wrote:
> as discussed via email, I think the entire manifest feature should be
implement
> in content
> 
> we don't have special support for other <link> elements not used by blink
> either. so not lgtm

It seems reasonable to me to have Blink returning the URL of the document's
manifest. How would you want this to be implemented instead? Would you want
content/ to parse the document's header to find the right <link> instead? That
sounds unfortunate given that we already have Document::linkManifest() in blink.

[jochen (gone - plz use gerrit), 2014-09-08 11:58:20]

On 2014/09/08 at 11:23:28, mlamouri wrote:
> On 2014/09/08 11:08:11, jochen wrote:
> > as discussed via email, I think the entire manifest feature should be
implement
> > in content
> > 
> > we don't have special support for other <link> elements not used by blink
> > either. so not lgtm
> 
> It seems reasonable to me to have Blink returning the URL of the document's
manifest. How would you want this to be implemented instead? Would you want
content/ to parse the document's header to find the right <link> instead? That
sounds unfortunate given that we already have Document::linkManifest() in blink.

mhm
why not expose it on WebDocument then, similar to openSearchDescriptionURL?

[mlamouri (slow - plz ping), 2014-09-08 14:35:22]

It's now exposed to WebDocument. That was exposed to WebLocalFrame because most
calls seem to happen via the frame instead of directly trough the document.

PTAL.

[jochen (gone - plz use gerrit), 2014-09-09 08:09:33]

lgtm

[mlamouri (slow - plz ping), 2014-09-09 09:06:57]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-09-09 09:07:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/535283003/20001

[commit-bot: I haz the power, 2014-09-09 09:10:43]

Committed patchset #2 (id:20001) as 181624