Translate activation/romaing state, restricted pool

chrome/browser/resources/options/chromeos/onc_data.js

Index: chrome/browser/resources/options/chromeos/onc_data.js
diff --git a/chrome/browser/resources/options/chromeos/onc_data.js b/chrome/browser/resources/options/chromeos/onc_data.js
index 78e25a7170f8ae302867cc125c0a0ab4628f5a73..eeaf58c53b872a5834bdc8f830980161fd71fb5e 100644
--- a/chrome/browser/resources/options/chromeos/onc_data.js
+++ b/chrome/browser/resources/options/chromeos/onc_data.js
@@ -100,7 +100,9 @@ cr.define('cr.onc', function() {
      */
     getTranslatedValue: function(key) {
       var value = this.getActiveValue(key);
-      if (typeof value != 'string')
+      if (typeof value == 'boolean')
+        value = value ? 'True' : 'False';

[pneubeck (no reviews), 2014/09/05 16:05:44]

this could always map to the translation of 'True' and 'False', independent of
the key,

or you could have a special handling for key==Restricted to map only in that
case to the translation of True/False.

[stevenjb, 2014/09/05 16:54:21]

Sometimes we may want to map 'True' -> "True", other times to "Yes" or something
more verbose. This seemed like a simple/consistent way to handle contextual
translation.

+      else if (typeof value != 'string')
         return value;

[pneubeck (no reviews), 2014/09/05 16:05:44]

nit: to prevent surprises, maybe convert |value| to string explicitly here
(using toString).

[stevenjb, 2014/09/05 16:54:21]

Until/unless we have a situation where we wanted to translate a non boolean or
string (and at the moment think of where me might), I would rather just return
the value here.

       var oncString = 'Onc' + key + value;
       // Handle special cases