Translate activation/romaing state, restricted pool

chrome/browser/resources/options/chromeos/onc_data.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview ONC Data support class. Wraps a dictionary object containing
  * ONC managed or unmanaged dictionaries. Supports nested dictionaries,
  * e.g. data.getManagedProperty('VPN.Type').
  */
 cr.define('cr.onc', function() {
@@ skipping 82 matching lines @@
     },
 
     /**
      * Gets the translated ONC value from the result of getActiveValue() using
      * loadTimeData. If no translation exists, returns the untranslated value.
      * @param {string} key The property key.
      * @return {*} The translation if available or the value if not.
      */
     getTranslatedValue: function(key) {
       var value = this.getActiveValue(key);
-      if (typeof value != 'string')
+      if (typeof value == 'boolean')
+        value = value ? 'True' : 'False';

[pneubeck (no reviews), 2014/09/05 16:05:44]

this could always map to the translation of 'True' and 'False', independent of
the key,

or you could have a special handling for key==Restricted to map only in that
case to the translation of True/False.

[stevenjb, 2014/09/05 16:54:21]

Sometimes we may want to map 'True' -> "True", other times to "Yes" or something
more verbose. This seemed like a simple/consistent way to handle contextual
translation.

+      else if (typeof value != 'string')
         return value;

[pneubeck (no reviews), 2014/09/05 16:05:44]

nit: to prevent surprises, maybe convert |value| to string explicitly here
(using toString).

[stevenjb, 2014/09/05 16:54:21]

Until/unless we have a situation where we wanted to translate a non boolean or
string (and at the moment think of where me might), I would rather just return
the value here.

       var oncString = 'Onc' + key + value;
       // Handle special cases
       if (key == 'Name' && this.type == 'Ethernet')
         return loadTimeData.getString('ethernetName');
       if (key == 'VPN.Type' && value == 'L2TP-IPsec') {
         var auth = this.getActiveValue('VPN.IPsec.AuthenticationType');
         if (auth != undefined)
           oncString += auth;
       }
       oncString = oncString.replace(/\./g, '-');
@@ skipping 32 matching lines @@
           return property[effective];
       }
       return undefined;
     }
   };
 
   return {
     OncData: OncData
   };
 });