Translate activation/romaing state, restricted pool

Translate activation/romaing state, restricted pool

BUG=279351
Committed: https://crrev.com/5a945c714ad657e09d159a2e2ed5d86eb87e38cb
Cr-Commit-Position: refs/heads/master@{#293621}

[stevenjb, 2014-09-03 18:14:24]

stevenjb@chromium.org changed reviewers:
+ armansito@chromium.org, pneubeck@chromium.org

[stevenjb, 2014-09-03 18:14:24]

This is a follow-up CL to 539573002 completing the current translations.

[stevenjb, 2014-09-04 17:03:19]

Updated tests to include added states.

[stevenjb, 2014-09-04 19:45:35]

Rebased, ptal.

[armansito, 2014-09-04 19:51:09]

lgtm

[pneubeck (no reviews), 2014-09-05 16:05:44]

Please unify the usages of 'Restricted' and 'RestrictedPool'. The latter is very
irritating IMO, because 'Pool' conveys no meaning to me.

Overall it looks good, just a few things for consideration:
1) _Maybe_ rename Restricted -> RestrictedConnectivity
2) _Maybe_ handle the "translation" of the value of the restricted field in
Javascript (I also mentioned it in inline comments):
  a) Use a checkbox instead of the strings 'Yes'/'No' (and their translation)

  b) Decide in Javascript (i.e. nearer to the actual UI) that you don't want to
show a translation of 'This network has restricted connectivity' but instead a
'Yes' or 'No'. I'm not even sure whether this can be translated without
providing the context.

early lgtm...

https://codereview.chromium.org/535283002/diff/60001/chrome/app/chromeos_stri...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/535283002/diff/60001/chrome/app/chromeos_stri...
chrome/app/chromeos_strings.grdp:3873: <message
name="IDS_OPTIONS_SETTINGS_INTERNET_CELLULAR_RESTRICTED_POOL" desc="Label for
cellular network restricted network access under chrome://options/internet">
IDS_OPTIONS_SETTINGS_INTERNET_CELLULAR_RESTRICTED_POOL
->
IDS_OPTIONS_SETTINGS_INTERNET_RESTRICTED (_CONNECTIVITY)

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/internet_detail.html (right):

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.html:111: <td
class="option-name" i18n-content="restrictedPool"></td>
All 'Restricted' fields could be shown as a checkbox and wouldn't require a
translation.

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:977: var
connectionState = onc.getActiveValue('ConnectionState');
nit: i see only one usage, could be inlined / the variable be removed.

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:978: var
connectionStateString = onc.getTranslatedValue('ConnectionState');
nit: move it a bit down, nearer to the first usage

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/onc_data.js (right):

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:104: value = value ?
'True' : 'False';
this could always map to the translation of 'True' and 'False', independent of
the key,

or you could have a special handling for key==Restricted to map only in that
case to the translation of True/False.

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:106: return value;
nit: to prevent surprises, maybe convert |value| to string explicitly here
(using toString).

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/ui/webui/...
File
chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc
(right):

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc:64:
{"OncRestrictedFalse", IDS_CONFIRM_MESSAGEBOX_NO_BUTTON_LABEL},
This is a bit irritating.
Why not making the decision in Javascript, to show a 'Yes'/'No' (button) label?

If it were a translation, then the right sight should somehow be related to
'RestrictedPool', e.g.
  for yes: "Internet connectivity is restricted."
  for no: "Internet has full connectivity."

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc:89:
{"restrictedPool", IDS_OPTIONS_SETTINGS_INTERNET_CELLULAR_RESTRICTED_POOL},
The '_CELLULAR' part on right side should be removed from the constant name.

https://codereview.chromium.org/535283002/diff/60001/components/onc/docs/onc_...
File components/onc/docs/onc_spec.html (right):

https://codereview.chromium.org/535283002/diff/60001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:391: <dt class="field">Restricted</dt>
for consideration:
When I read this CL again, and I had already forgotten what 'Restricted' should
mean, I had no clue about its meaning.

Maybe a more verbose name like 'RestrictedConnectivity' would be more intuitive?

[pneubeck (no reviews), 2014-09-05 16:05:45]

Please unify the usages of 'Restricted' and 'RestrictedPool'. The latter is very
irritating IMO, because 'Pool' conveys no meaning to me.

Overall it looks good, just a few things for consideration:
1) _Maybe_ rename Restricted -> RestrictedConnectivity
2) _Maybe_ handle the "translation" of the value of the restricted field in
Javascript (I also mentioned it in inline comments):
  a) Use a checkbox instead of the strings 'Yes'/'No' (and their translation)

  b) Decide in Javascript (i.e. nearer to the actual UI) that you don't want to
show a translation of 'This network has restricted connectivity' but instead a
'Yes' or 'No'. I'm not even sure whether this can be translated without
providing the context.

early lgtm...

https://codereview.chromium.org/535283002/diff/60001/chrome/app/chromeos_stri...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/535283002/diff/60001/chrome/app/chromeos_stri...
chrome/app/chromeos_strings.grdp:3873: <message
name="IDS_OPTIONS_SETTINGS_INTERNET_CELLULAR_RESTRICTED_POOL" desc="Label for
cellular network restricted network access under chrome://options/internet">
IDS_OPTIONS_SETTINGS_INTERNET_CELLULAR_RESTRICTED_POOL
->
IDS_OPTIONS_SETTINGS_INTERNET_RESTRICTED (_CONNECTIVITY)

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/internet_detail.html (right):

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.html:111: <td
class="option-name" i18n-content="restrictedPool"></td>
All 'Restricted' fields could be shown as a checkbox and wouldn't require a
translation.

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:977: var
connectionState = onc.getActiveValue('ConnectionState');
nit: i see only one usage, could be inlined / the variable be removed.

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:978: var
connectionStateString = onc.getTranslatedValue('ConnectionState');
nit: move it a bit down, nearer to the first usage

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/onc_data.js (right):

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:104: value = value ?
'True' : 'False';
this could always map to the translation of 'True' and 'False', independent of
the key,

or you could have a special handling for key==Restricted to map only in that
case to the translation of True/False.

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:106: return value;
nit: to prevent surprises, maybe convert |value| to string explicitly here
(using toString).

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/ui/webui/...
File
chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc
(right):

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc:64:
{"OncRestrictedFalse", IDS_CONFIRM_MESSAGEBOX_NO_BUTTON_LABEL},
This is a bit irritating.
Why not making the decision in Javascript, to show a 'Yes'/'No' (button) label?

If it were a translation, then the right sight should somehow be related to
'RestrictedPool', e.g.
  for yes: "Internet connectivity is restricted."
  for no: "Internet has full connectivity."

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc:89:
{"restrictedPool", IDS_OPTIONS_SETTINGS_INTERNET_CELLULAR_RESTRICTED_POOL},
The '_CELLULAR' part on right side should be removed from the constant name.

https://codereview.chromium.org/535283002/diff/60001/components/onc/docs/onc_...
File components/onc/docs/onc_spec.html (right):

https://codereview.chromium.org/535283002/diff/60001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:391: <dt class="field">Restricted</dt>
for consideration:
When I read this CL again, and I had already forgotten what 'Restricted' should
mean, I had no clue about its meaning.

Maybe a more verbose name like 'RestrictedConnectivity' would be more intuitive?

[stevenjb, 2014-09-05 16:27:53]

Responding first just to the top level comments:

On Fri, Sep 5, 2014 at 10:05 AM, <pneubeck@chromium.org> wrote:

> Please unify the usages of 'Restricted' and 'RestrictedPool'. The latter
> is very
> irritating IMO, because 'Pool' conveys no meaning to me.
>
I think 'pool' is only used in the IDS name, which I'd just as soon not
change since we're not changing the string, but I'll double check that.

Overall it looks good, just a few things for consideration:
> 1) _Maybe_ rename Restricted -> RestrictedConnectivity
>
Sure, that makes sense.


> 2) _Maybe_ handle the "translation" of the value of the restricted field in
> Javascript (I also mentioned it in inline comments):
>   a) Use a checkbox instead of the strings 'Yes'/'No' (and their
> translation)
>
I don't think this is a good idea from a UX perspective since the user can
not change the value. I also want to minimize visible changes at this point
to simplify testing. If anything I could be persuaded not to show the
'RestrictedConnectivity' state for wifi/wimax in this CL.

>
>   b) Decide in Javascript (i.e. nearer to the actual UI) that you don't
> want to
> show a translation of 'This network has restricted connectivity' but
> instead a
> 'Yes' or 'No'. I'm not even sure whether this can be translated without
> providing the context.
>
I'm not sure I understand your suggestion 100%, but again I think any UX
design should wait. The intention is definitely to eventually have any UI
logic in JS...


> early lgtm...
>
>
> https://codereview.chromium.org/535283002/diff/60001/
> chrome/app/chromeos_strings.grdp
> File chrome/app/chromeos_strings.grdp (right):
>
> https://codereview.chromium.org/535283002/diff/60001/
> chrome/app/chromeos_strings.grdp#newcode3873
> chrome/app/chromeos_strings.grdp:3873: <message
> name="IDS_OPTIONS_SETTINGS_INTERNET_CELLULAR_RESTRICTED_POOL"
> desc="Label for cellular network restricted network access under
> chrome://options/internet">
> IDS_OPTIONS_SETTINGS_INTERNET_CELLULAR_RESTRICTED_POOL
> ->
> IDS_OPTIONS_SETTINGS_INTERNET_RESTRICTED (_CONNECTIVITY)
>
> https://codereview.chromium.org/535283002/diff/60001/
> chrome/browser/resources/options/chromeos/internet_detail.html
> File chrome/browser/resources/options/chromeos/internet_detail.html
> (right):
>
> https://codereview.chromium.org/535283002/diff/60001/
> chrome/browser/resources/options/chromeos/internet_detail.html#newcode111
> chrome/browser/resources/options/chromeos/internet_detail.html:111: <td
> class="option-name" i18n-content="restrictedPool"></td>
> All 'Restricted' fields could be shown as a checkbox and wouldn't
> require a translation.
>
> https://codereview.chromium.org/535283002/diff/60001/
> chrome/browser/resources/options/chromeos/internet_detail.js
> File chrome/browser/resources/options/chromeos/internet_detail.js
> (right):
>
> https://codereview.chromium.org/535283002/diff/60001/
> chrome/browser/resources/options/chromeos/internet_detail.js#newcode977
> chrome/browser/resources/options/chromeos/internet_detail.js:977: var
> connectionState = onc.getActiveValue('ConnectionState');
> nit: i see only one usage, could be inlined / the variable be removed.
>
> https://codereview.chromium.org/535283002/diff/60001/
> chrome/browser/resources/options/chromeos/internet_detail.js#newcode978
> chrome/browser/resources/options/chromeos/internet_detail.js:978: var
> connectionStateString = onc.getTranslatedValue('ConnectionState');
> nit: move it a bit down, nearer to the first usage
>
> https://codereview.chromium.org/535283002/diff/60001/
> chrome/browser/resources/options/chromeos/onc_data.js
> File chrome/browser/resources/options/chromeos/onc_data.js (right):
>
> https://codereview.chromium.org/535283002/diff/60001/
> chrome/browser/resources/options/chromeos/onc_data.js#newcode104
> chrome/browser/resources/options/chromeos/onc_data.js:104: value = value
> ? 'True' : 'False';
> this could always map to the translation of 'True' and 'False',
> independent of the key,
>
> or you could have a special handling for key==Restricted to map only in
> that case to the translation of True/False.
>
> https://codereview.chromium.org/535283002/diff/60001/
> chrome/browser/resources/options/chromeos/onc_data.js#newcode106
> chrome/browser/resources/options/chromeos/onc_data.js:106: return value;
> nit: to prevent surprises, maybe convert |value| to string explicitly
> here (using toString).
>
> https://codereview.chromium.org/535283002/diff/60001/
> chrome/browser/ui/webui/options/chromeos/internet_
> options_handler_strings.cc
> File
> chrome/browser/ui/webui/options/chromeos/internet_
> options_handler_strings.cc
> (right):
>
> https://codereview.chromium.org/535283002/diff/60001/
> chrome/browser/ui/webui/options/chromeos/internet_
> options_handler_strings.cc#newcode64
> chrome/browser/ui/webui/options/chromeos/internet_
> options_handler_strings.cc:64:
> {"OncRestrictedFalse", IDS_CONFIRM_MESSAGEBOX_NO_BUTTON_LABEL},
> This is a bit irritating.
> Why not making the decision in Javascript, to show a 'Yes'/'No' (button)
> label?
>
> If it were a translation, then the right sight should somehow be related
> to 'RestrictedPool', e.g.
>   for yes: "Internet connectivity is restricted."
>   for no: "Internet has full connectivity."
>
> https://codereview.chromium.org/535283002/diff/60001/
> chrome/browser/ui/webui/options/chromeos/internet_
> options_handler_strings.cc#newcode89
> chrome/browser/ui/webui/options/chromeos/internet_
> options_handler_strings.cc:89:
> {"restrictedPool",
> IDS_OPTIONS_SETTINGS_INTERNET_CELLULAR_RESTRICTED_POOL},
> The '_CELLULAR' part on right side should be removed from the constant
> name.
>
> https://codereview.chromium.org/535283002/diff/60001/
> components/onc/docs/onc_spec.html
> File components/onc/docs/onc_spec.html (right):
>
> https://codereview.chromium.org/535283002/diff/60001/
> components/onc/docs/onc_spec.html#newcode391
> components/onc/docs/onc_spec.html:391: <dt class="field">Restricted</dt>
> for consideration:
> When I read this CL again, and I had already forgotten what 'Restricted'
> should mean, I had no clue about its meaning.
>
> Maybe a more verbose name like 'RestrictedConnectivity' would be more
> intuitive?
>
> https://codereview.chromium.org/535283002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[stevenjb, 2014-09-05 16:54:21]

I'm checking the CQ box to get the tests running, but please feel free to
comment further if there are still concerns / suggestions.

https://codereview.chromium.org/535283002/diff/60001/chrome/app/chromeos_stri...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/535283002/diff/60001/chrome/app/chromeos_stri...
chrome/app/chromeos_strings.grdp:3873: <message
name="IDS_OPTIONS_SETTINGS_INTERNET_CELLULAR_RESTRICTED_POOL" desc="Label for
cellular network restricted network access under chrome://options/internet">
On 2014/09/05 16:05:43, pneubeck wrote:
> IDS_OPTIONS_SETTINGS_INTERNET_CELLULAR_RESTRICTED_POOL
> ->
> IDS_OPTIONS_SETTINGS_INTERNET_RESTRICTED (_CONNECTIVITY)

I'd rather not rename this and make extra work for translators until/unless we
change the text.

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/internet_detail.html (right):

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.html:111: <td
class="option-name" i18n-content="restrictedPool"></td>
On 2014/09/05 16:05:44, pneubeck wrote:
> All 'Restricted' fields could be shown as a checkbox and wouldn't require a
> translation.

As mentioned earlier, I don't want to change the UX design here. I think it is
useful so would rather include it in a consistent way with how we do Cellular,
but if that seems confusing to you I can omit it until we get a UX design.

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:977: var
connectionState = onc.getActiveValue('ConnectionState');
On 2014/09/05 16:05:44, pneubeck wrote:
> nit: i see only one usage, could be inlined / the variable be removed.

Done.

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:978: var
connectionStateString = onc.getTranslatedValue('ConnectionState');
On 2014/09/05 16:05:44, pneubeck wrote:
> nit: move it a bit down, nearer to the first usage

Done.

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/onc_data.js (right):

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:104: value = value ?
'True' : 'False';
On 2014/09/05 16:05:44, pneubeck wrote:
> this could always map to the translation of 'True' and 'False', independent of
> the key,
> 
> or you could have a special handling for key==Restricted to map only in that
> case to the translation of True/False.

Sometimes we may want to map 'True' -> "True", other times to "Yes" or something
more verbose. This seemed like a simple/consistent way to handle contextual
translation.

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:106: return value;
On 2014/09/05 16:05:44, pneubeck wrote:
> nit: to prevent surprises, maybe convert |value| to string explicitly here
> (using toString).

Until/unless we have a situation where we wanted to translate a non boolean or
string (and at the moment think of where me might), I would rather just return
the value here.

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/ui/webui/...
File
chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc
(right):

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc:64:
{"OncRestrictedFalse", IDS_CONFIRM_MESSAGEBOX_NO_BUTTON_LABEL},
On 2014/09/05 16:05:44, pneubeck wrote:
> This is a bit irritating.
> Why not making the decision in Javascript, to show a 'Yes'/'No' (button)
label?
> 
> If it were a translation, then the right sight should somehow be related to
> 'RestrictedPool', e.g.
>   for yes: "Internet connectivity is restricted."
>   for no: "Internet has full connectivity."

Let's leave this as-is for now. If we re design it and still want to say 'YES'
or 'NO' for restricted pool, we should add context specific strings here. I will
add a TODO.

https://codereview.chromium.org/535283002/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc:89:
{"restrictedPool", IDS_OPTIONS_SETTINGS_INTERNET_CELLULAR_RESTRICTED_POOL},
On 2014/09/05 16:05:44, pneubeck wrote:
> The '_CELLULAR' part on right side should be removed from the constant name.
Added a TODO here.

https://codereview.chromium.org/535283002/diff/60001/components/onc/docs/onc_...
File components/onc/docs/onc_spec.html (right):

https://codereview.chromium.org/535283002/diff/60001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:391: <dt class="field">Restricted</dt>
On 2014/09/05 16:05:44, pneubeck wrote:
> for consideration:
> When I read this CL again, and I had already forgotten what 'Restricted'
should
> mean, I had no clue about its meaning.
> 
> Maybe a more verbose name like 'RestrictedConnectivity' would be more
intuitive?

Done.

[stevenjb, 2014-09-05 16:54:26]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-09-05 16:55:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/stevenjb@chromium.org/535283002/100001

[stevenjb, 2014-09-05 16:56:04]

The CQ bit was unchecked by stevenjb@chromium.org

[stevenjb, 2014-09-05 16:56:23]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-09-05 16:57:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/stevenjb@chromium.org/535283002/120001

[commit-bot: I haz the power, 2014-09-05 17:11:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 17:11:25]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2014-09-05 19:41:42]

Patchset #8 (id:140001) has been deleted

[stevenjb, 2014-09-05 19:43:42]

I changed the code to only set 'RestrictedConnectivity' if True to simplify
tests and fixed+updated the spec. I also moved the translation logic to the JS
as suggested rather than complicate the code in getTranslatedValue (which now
only supports strings).

[stevenjb, 2014-09-05 19:43:47]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-09-05 19:44:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/stevenjb@chromium.org/535283002/160001

[commit-bot: I haz the power, 2014-09-05 21:44:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 21:44:40]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[stevenjb, 2014-09-05 23:53:29]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-09-05 23:54:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/stevenjb@chromium.org/535283002/160001

[commit-bot: I haz the power, 2014-09-06 07:46:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-06 07:46:24]

Exceeded time limit waiting for builds to trigger.

[stevenjb, 2014-09-06 15:40:10]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-09-06 15:40:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/stevenjb@chromium.org/535283002/160001

[commit-bot: I haz the power, 2014-09-06 18:37:09]

Committed patchset #8 (id:160001) as 5f2f77726ef6ef19e14d952b2e94687262da89ab

[commit-bot: I haz the power, 2014-09-10 03:42:50]

Patchset 8 (id:??) landed as
https://crrev.com/5a945c714ad657e09d159a2e2ed5d86eb87e38cb
Cr-Commit-Position: refs/heads/master@{#293621}