Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 535203003: Replace Profile* in declarative_api with BrowserContext* (Closed)

Created:
6 years, 3 months ago by wjmaclean
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace Profile* in declarative_api with BrowserContext* This will remove the dependence of these files on chrome/browser/profiles/profile.h, in preparation for their move to extensions/browser/api/declarative. BUG=352293 Committed: https://crrev.com/5b11eee25e31c345c1fb3c8d47f6e5dfde14bc37 Cr-Commit-Position: refs/heads/master@{#293384}

Patch Set 1 #

Patch Set 2 : Remove changes to unit-test; those have to wait until move. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -105 lines) Patch
M chrome/browser/extensions/api/automation_internal/automation_internal_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_api.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/rules_cache_delegate.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_cache_delegate.cc View 10 chunks +24 lines, -23 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry.h View 4 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service.h View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/declarative/test_rules_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/test_rules_registry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_action.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_action.cc View 3 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_rules_registry.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_rules_registry.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/infobars/infobar_extension_api.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
wjmaclean
The tests aren't all fixed yet, but here is the new-look CL.
6 years, 3 months ago (2014-09-03 17:20:01 UTC) #2
Fady Samuel
looks good so far.
6 years, 3 months ago (2014-09-03 17:28:01 UTC) #3
wjmaclean
After some examination, I think we'll have to forgo the removal of TestingProfile from rules_registry_service_unittest.cc ...
6 years, 3 months ago (2014-09-03 18:27:54 UTC) #4
wjmaclean
rockot@chromium.org: Please review changes in chrome/browser/extensions/* sky@chromium.org: Please review changes in chrome/browser/infobars/inforbar_extension_api.cc
6 years, 3 months ago (2014-09-03 18:31:09 UTC) #6
sky
chrome/browser/infobars/infobar_extension_api.cc LGTm - feel free to TBR this sort of change in the future.
6 years, 3 months ago (2014-09-03 21:23:20 UTC) #7
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-04 00:58:02 UTC) #8
Fady Samuel
lgtm
6 years, 3 months ago (2014-09-04 12:15:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/535203003/20001
6 years, 3 months ago (2014-09-04 12:44:30 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0c4684adde6983d02cdaf7e5213c2dfdba8307c1
6 years, 3 months ago (2014-09-05 00:56:36 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:34:23 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b11eee25e31c345c1fb3c8d47f6e5dfde14bc37
Cr-Commit-Position: refs/heads/master@{#293384}

Powered by Google App Engine
This is Rietveld 408576698