Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 535173003: Pull buildtools to get GN r293190 (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Pull buildtools to get GN r293190 TBR=jamesr Committed: https://crrev.com/babd228391d379b59d5f60befb76ce0640aad90e Cr-Commit-Position: refs/heads/master@{#293269}

Patch Set 1 #

Patch Set 2 : fix sources assignment filter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/config/BUILDCONFIG.gn View 1 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
brettw
6 years, 3 months ago (2014-09-03 21:11:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/535173003/20001
6 years, 3 months ago (2014-09-03 23:23:40 UTC) #3
jamesr
lgtm
6 years, 3 months ago (2014-09-03 23:26:32 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1889)
6 years, 3 months ago (2014-09-04 02:01:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/535173003/20001
6 years, 3 months ago (2014-09-04 03:09:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/535173003/20001
6 years, 3 months ago (2014-09-04 03:20:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2001)
6 years, 3 months ago (2014-09-04 04:13:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/535173003/20001
6 years, 3 months ago (2014-09-04 05:37:00 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 92832ae1c97efad4a7e8cd20469e2b64c7bc29a4
6 years, 3 months ago (2014-09-04 06:02:49 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:30:15 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/babd228391d379b59d5f60befb76ce0640aad90e
Cr-Commit-Position: refs/heads/master@{#293269}

Powered by Google App Engine
This is Rietveld 408576698