Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 535153003: Revert of Recorded additional tough_energy_cases. (Closed)

Created:
6 years, 3 months ago by sullivan
Modified:
6 years, 3 months ago
Reviewers:
tonyg, jeremy
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Recorded additional tough_energy_cases. (patchset #1 id:1 of https://codereview.chromium.org/506063002/) Reason for revert: Errors: "WARNING:root:The page set archives for some pages are missing. Someone forgot to check them in, or they were deleted. Skipping those pages. To fix this, record those pages using record_wpr. To ignore this warning and run against live sites, pass the flag --use-live-sites." Example: http://chromegw/i/chromium.perf/builders/Win%208%20Perf%20%282%29/builds/3086/steps/tab_switching.tough_energy_cases/logs/stdio Original issue's description: > PERF SHERIFF: This CL changes the tough_energy_cases test. > > Recorded additional tough_energy_cases. > Moved all test cases to codepen, so they're easy to edit and all http. > > BUG=386152 > > Committed: https://chromium.googlesource.com/chromium/src/+/f4919a56f8dde79db10d158940bab9b5a95688f0 TBR=tonyg@chromium.org,jeremy@chromium.org NOTREECHECKS=true NOTRY=true BUG=386152 Committed: https://crrev.com/201a6a421614a4192c1b83701ea410c73c70e2dd Cr-Commit-Position: refs/heads/master@{#293136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -112 lines) Patch
M tools/perf/page_sets/data/tough_energy_cases.json View 1 chunk +2 lines, -21 lines 0 comments Download
M tools/perf/page_sets/tough_energy_cases.py View 2 chunks +25 lines, -91 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sullivan
Created Revert of Recorded additional tough_energy_cases.
6 years, 3 months ago (2014-09-03 14:51:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sullivan@chromium.org/535153003/1
6 years, 3 months ago (2014-09-03 14:52:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as fbb2fdc37dcc5757f6bcc17a072457b59697a146
6 years, 3 months ago (2014-09-03 15:03:28 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:25:44 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/201a6a421614a4192c1b83701ea410c73c70e2dd
Cr-Commit-Position: refs/heads/master@{#293136}

Powered by Google App Engine
This is Rietveld 408576698