Issue 535133002: Remove usages of alloca() according to style guide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 535133002: Remove usages of alloca() according to style guide. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger

Modified:
6 years, 3 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -12 lines)			Patch
M	src/compiler/ast-graph-builder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/graph-builder.cc	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	src/compiler/machine-node-factory.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/compiler/structured-machine-assembler.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Starzinger

According to the C++ style guide all usages of alloca() are disallowed. Some of our ...

6 years, 3 months ago (2014-09-03 13:14:17 UTC) #1

Michael Starzinger

6 years, 3 months ago (2014-09-03 13:23:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23657 (presubmit successful).