Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 53513003: ash: Rename GetLauncherItemIndexForType to GetShelfItemIndexForType(). (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

ash: Rename GetLauncherItemIndexForType to GetShelfItemIndexForType(). - move launcher_model_util.* from launcher/ to shelf/ - rename to shelf_model_util.* BUG=248353 TEST=None, no functional changes R=harrym@chromium.org,jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232415

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -76 lines) Patch
M ash/ash.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
D ash/launcher/launcher_model_util.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ash/launcher/launcher_model_util.cc View 1 chunk +0 lines, -20 lines 0 comments Download
A + ash/shelf/shelf_model_util.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ash/shelf/shelf_model_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/shell.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 10 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
7 years, 1 month ago (2013-10-31 01:44:20 UTC) #1
Harry McCleave
lgtm
7 years, 1 month ago (2013-10-31 22:42:42 UTC) #2
James Cook
LGTM, and thanks for doing this. The launcher to shelf conversion will really help new ...
7 years, 1 month ago (2013-11-01 00:10:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/53513003/110001
7 years, 1 month ago (2013-11-01 01:13:30 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=96172
7 years, 1 month ago (2013-11-01 06:29:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/53513003/110001
7 years, 1 month ago (2013-11-01 12:57:39 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 16:58:57 UTC) #7
Message was sent while issue was closed.
Change committed as 232415

Powered by Google App Engine
This is Rietveld 408576698