Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 535103002: CallDescriptors::InitializeForIsolate() is no longer needed. (Closed)

Created:
6 years, 3 months ago by mvstanton
Modified:
6 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

CallDescriptors::InitializeForIsolate() is no longer needed. CallInterfaceDescriptors initialize themselves lazily. Soon we can also tear down the CodeStubInterfaceDescriptor explicit initialization step. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -271 lines) Patch
M src/arm/interface-descriptors-arm.cc View 7 chunks +63 lines, -58 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 8 chunks +63 lines, -58 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 7 chunks +58 lines, -58 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +7 lines, -15 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +11 lines, -22 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 7 chunks +58 lines, -58 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Yang, Per your earlier advice, this tears down an unnecessary initialization. PTAL, thanks! --Michael
6 years, 3 months ago (2014-09-03 11:57:12 UTC) #1
Yang
On 2014/09/03 11:57:12, mvstanton wrote: > Hi Yang, > Per your earlier advice, this tears ...
6 years, 3 months ago (2014-09-03 11:58:58 UTC) #2
mvstanton
6 years, 3 months ago (2014-09-03 12:25:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698