Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1643)

Issue 535083002: Make 'New folder' text font style to default instead of bold. (Closed)

Created:
6 years, 3 months ago by siba.samal
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make 'New folder' text font style to default instead of bold. XIB Changes: Font style for 'New folder' title in BookmarksAllTabs and BookmarkEditor window is set in .xib files placed at following locations. chrome/app/nibs/BookmarkAllTabs.xib chrome/app/nibs/BookmarkEditor.xib Removing the 'fontBold' key string for the 'newFolder' object. BUG=397086 R=asvitkine@chromium.org TEST= 1) Launch chrome and bookmark any page. 2) Now in the Bookmarks bar right click on the bookmarked page and click on edit. 3) In the edit box click on 'New folder' and observe. 4) The 'New folder' name font style should not be bold. Committed: https://crrev.com/08ee29675d6fb4071d8703a89264b8222d07ac28 Cr-Commit-Position: refs/heads/master@{#294336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M chrome/app/nibs/BookmarkAllTabs.xib View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/app/nibs/BookmarkEditor.xib View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
siba.samal
PTAL.
6 years, 3 months ago (2014-09-03 11:48:56 UTC) #1
siba.samal
On 2014/09/03 11:48:56, siba.samal wrote: > PTAL. @asvitkine PTAL.
6 years, 3 months ago (2014-09-09 05:41:37 UTC) #2
Alexei Svitkine (slow)
Sorry, didn't get to it today. Will take a look tomorrow. On Tue, Sep 9, ...
6 years, 3 months ago (2014-09-09 21:29:36 UTC) #3
Alexei Svitkine (slow)
LGTM, please add a "XIB Changes:" section to describe the changes you did.
6 years, 3 months ago (2014-09-10 20:58:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/535083002/1
6 years, 3 months ago (2014-09-11 04:13:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4422ad96ab05b3869a5f1d34fa0687978620c93f
6 years, 3 months ago (2014-09-11 06:05:26 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 06:09:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08ee29675d6fb4071d8703a89264b8222d07ac28
Cr-Commit-Position: refs/heads/master@{#294336}

Powered by Google App Engine
This is Rietveld 408576698