Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 53503004: Restore focus when infobar closes. (Closed)

Created:
7 years, 1 month ago by dmazzoni
Modified:
7 years, 1 month ago
CC:
chromium-reviews, tfarina, fil, klevy_google.com
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Restore focus when infobar closes. This was already implemented for non-aura Win, this just makes it work on Aura Win and Chrome OS too. BUG=179892 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/ui/views/infobars/infobar_view.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dmazzoni
7 years, 1 month ago (2013-11-01 19:32:42 UTC) #1
Peter Kasting
Rubber-stamp LGTM; if you need a more expert opinion on whether Widget::IsActive() is correct, someone ...
7 years, 1 month ago (2013-11-04 22:52:24 UTC) #2
dmazzoni
+ben (Ben, would you make sure this is reasonable?)
7 years, 1 month ago (2013-11-04 22:57:33 UTC) #3
Ben Goodger (Google)
lgtm
7 years, 1 month ago (2013-11-05 17:45:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/53503004/1
7 years, 1 month ago (2013-11-05 17:51:33 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-05 18:26:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/53503004/1
7 years, 1 month ago (2013-11-06 23:31:36 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-07 00:01:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/53503004/1
7 years, 1 month ago (2013-11-07 00:51:45 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 06:16:46 UTC) #10
Message was sent while issue was closed.
Change committed as 233499

Powered by Google App Engine
This is Rietveld 408576698