Mojo: Cancel WaitingCallbacks when their HandleWrappers are closed.

mojo/bindings/js/waiting_callback.cc

Index: mojo/bindings/js/waiting_callback.cc
diff --git a/mojo/bindings/js/waiting_callback.cc b/mojo/bindings/js/waiting_callback.cc
index 692551bb0e7d309db93b8b9c4933adbfc863411c..e2f2a40ba8efdeda8d8bf51e205652cd9d26bd24 100644
--- a/mojo/bindings/js/waiting_callback.cc
+++ b/mojo/bindings/js/waiting_callback.cc
@@ -24,12 +24,12 @@ gin::WrapperInfo WaitingCallback::kWrapperInfo = { gin::kEmbedderNativeGin };
 gin::Handle<WaitingCallback> WaitingCallback::Create(
     v8::Isolate* isolate,
     v8::Handle<v8::Function> callback,
-    mojo::Handle handle,
+    gin::Handle<gin::HandleWrapper> handle_wrapper,
     MojoHandleSignals signals) {
-  gin::Handle<WaitingCallback> waiting_callback =
-      gin::CreateHandle(isolate, new WaitingCallback(isolate, callback));
+  gin::Handle<WaitingCallback> waiting_callback = gin::CreateHandle(
+      isolate, new WaitingCallback(isolate, callback, handle_wrapper));
   waiting_callback->wait_id_ = Environment::GetDefaultAsyncWaiter()->AsyncWait(
-      handle.value(),
+      handle_wrapper->get().value(),
       signals,
       MOJO_DEADLINE_INDEFINITE,
       &WaitingCallback::CallOnHandleReady,
@@ -41,13 +41,17 @@ void WaitingCallback::Cancel() {
   if (!wait_id_)
     return;
 
+  handle_wrapper_->RemoveCloseObserver(this);
+  handle_wrapper_ = NULL;
   Environment::GetDefaultAsyncWaiter()->CancelWait(wait_id_);
   wait_id_ = 0;
 }
 
 WaitingCallback::WaitingCallback(v8::Isolate* isolate,
-                                 v8::Handle<v8::Function> callback)
-      : wait_id_() {
+                                 v8::Handle<v8::Function> callback,
+                                 gin::Handle<gin::HandleWrapper> handle_wrapper)
+    : wait_id_(), handle_wrapper_(handle_wrapper.get()) {

[sky, 2014/09/03 15:47:04]

0?

[Sam McNally, 2014/09/08 04:31:52]

Done.

+  handle_wrapper_->AddCloseObserver(this);
   v8::Handle<v8::Context> context = isolate->GetCurrentContext();
   runner_ = gin::PerContextData::From(context)->runner()->GetWeakPtr();
   GetWrapper(isolate)->SetHiddenValue(GetHiddenPropertyName(isolate), callback);
@@ -64,6 +68,8 @@ void WaitingCallback::CallOnHandleReady(void* closure, MojoResult result) {
 
 void WaitingCallback::OnHandleReady(MojoResult result) {
   wait_id_ = 0;
+  handle_wrapper_->RemoveCloseObserver(this);
+  handle_wrapper_ = NULL;
 
   if (!runner_)
     return;
@@ -80,5 +86,10 @@ void WaitingCallback::OnHandleReady(MojoResult result) {
   runner_->Call(callback, runner_->global(), 1, args);
 }
 
+void WaitingCallback::OnHandleClosed() {
+  Environment::GetDefaultAsyncWaiter()->CancelWait(wait_id_);
+  OnHandleReady(MOJO_RESULT_INVALID_ARGUMENT);
+}
+
 }  // namespace js
 }  // namespace mojo