Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 53493003: Turn on useUnfortunateSynchronousResizeMode. (Closed)

Created:
7 years, 1 month ago by dglazkov
Modified:
7 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Turn on useUnfortunateSynchronousResizeMode. I had to add a RenderViewVisitor to ensure that all secondary windows get their resize mode values applied properly, but other than that, this is a simple flipping-the-flag type of thing. BUG=309760 R=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233069

Patch Set 1 #

Patch Set 2 : Fix browsertests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M content/renderer/render_widget.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/resizing_mode_selector.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/resizing_mode_selector.cc View 1 2 chunks +6 lines, -9 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
dglazkov
7 years, 1 month ago (2013-10-30 22:14:31 UTC) #1
jam
lgtm
7 years, 1 month ago (2013-10-31 06:20:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/53493003/90001
7 years, 1 month ago (2013-11-04 21:36:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/53493003/90001
7 years, 1 month ago (2013-11-05 03:11:36 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184813
7 years, 1 month ago (2013-11-05 06:20:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/53493003/90001
7 years, 1 month ago (2013-11-05 15:47:26 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=185186
7 years, 1 month ago (2013-11-05 18:26:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/53493003/90001
7 years, 1 month ago (2013-11-05 18:43:01 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 20:20:58 UTC) #9
Message was sent while issue was closed. 
Change committed as 233069

Powered by Google App Engine
This is Rietveld 408576698