Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 534853002: Reduce number of roundtrips required in XMPP handshake (Closed)

Created:
6 years, 3 months ago by Sergey Ulanov
Modified:
6 years, 3 months ago
Reviewers:
Jamie, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@webapp_tls
Project:
chromium
Visibility:
Public.

Description

Reduce number of roundtrips required in XMPP handshake Previously XMPP handshake implemented in XmppLoginHandler required 7 roundtrips (excluding TLS handshake). With this change it will be sending each message as soon as possible without waiting response to the previous message. This effectivelly reduces number of required roundtrips to 3. BUG=274652 Committed: https://crrev.com/a55e1da00db331b8199a6a396fae7fc7a0ad715c Cr-Commit-Position: refs/heads/master@{#293389}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -109 lines) Patch
M remoting/webapp/unittests/xmpp_login_handler_unittest.js View 1 3 chunks +49 lines, -45 lines 0 comments Download
M remoting/webapp/xmpp_login_handler.js View 1 8 chunks +63 lines, -64 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sergey Ulanov
6 years, 3 months ago (2014-09-03 00:53:33 UTC) #2
kelvinp
lgtm
6 years, 3 months ago (2014-09-03 01:10:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/534853002/20001
6 years, 3 months ago (2014-09-04 21:10:22 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6ee74d0885a5b7c68e696addac05d09b4b71d8cf
6 years, 3 months ago (2014-09-05 01:18:42 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:34:38 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a55e1da00db331b8199a6a396fae7fc7a0ad715c
Cr-Commit-Position: refs/heads/master@{#293389}

Powered by Google App Engine
This is Rietveld 408576698