mojo/examples/surfaces_app/surfaces_app.cc - Issue 534843002: Convert view manager to surfaces with uploading shim in client lib

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/examples/surfaces_app/surfaces_app.cc

Issue 534843002: Convert view manager to surfaces with uploading shim in client lib (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove overzealous shutdown check in cc/surfaces, add NON_EXPORTED_BASE for windows build, saturate… Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/examples/surfaces_app/surfaces_app.cc

diff --git a/mojo/examples/surfaces_app/surfaces_app.cc b/mojo/examples/surfaces_app/surfaces_app.cc

index df24e7017026b874e0106e70b4873a4fe0b70676..c34c0e5cab430d4ea45e8f1d57dc46803e5cb9e0 100644

--- a/mojo/examples/surfaces_app/surfaces_app.cc

+++ b/mojo/examples/surfaces_app/surfaces_app.cc

@@ -46,7 +46,7 @@ class SurfacesApp : public ApplicationDelegate,

size_ = gfx::Size(800, 600);

- viewport_->Create(Rect::From(gfx::Rect(gfx::Point(10, 10), size_)));

+ viewport_->Create(Size::From(size_));

viewport_->Show();

child_size_ = gfx::Size(size_.width() / 3, size_.height() / 2);

@@ -104,7 +104,7 @@ class SurfacesApp : public ApplicationDelegate,

}

// NativeViewportClient implementation.

virtual void OnCreated(uint64_t native_viewport_id) OVERRIDE {}

- virtual void OnBoundsChanged(mojo::RectPtr bounds) OVERRIDE {}

+ virtual void OnBoundsChanged(mojo::SizePtr bounds) OVERRIDE {}

virtual void OnDestroyed() OVERRIDE {}

virtual void OnEvent(mojo::EventPtr event,

const mojo::Callback<void()>& callback) OVERRIDE {

« no previous file with comments | « mojo/examples/sample_app/sample_app.cc ('k') | mojo/mojo.gyp » ('j') | no next file with comments »