Issue 534823002: cc: Don't infinitely throttle large raster tasks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 534823002: cc: Don't infinitely throttle large raster tasks (Closed)

Created:
6 years, 3 months ago by enne (OOO)

Modified:
6 years, 3 months ago

Reviewers:
reveman

CC:
cc-bugs_chromium.org, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

More Reviews

Description

cc: Don't infinitely throttle large raster tasks Previously, if a raster task had a resource size that was larger than the throttling limit for the raster worker, that task would never get scheduled. This leads to starvation for that task, preventing tree activation, and causing freezes. The fix is to always allow such large tasks if it is the first task. TBR=reveman@chromium.org BUG=403446 Review URL: https://codereview.chromium.org/489293002 Cr-Commit-Position: refs/heads/master@{#291484} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291484 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit 604e202d3548b701900c3771f9517103bb91486c) Committed: https://chromium.googlesource.com/chromium/src/+/ed161531ce079ce4a467c4ad4e47dc56c48800c2

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -6 lines)			Patch
	M	cc/resources/pixel_buffer_raster_worker_pool.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
	M	cc/resources/raster_worker_pool_unittest.cc	View		5 chunks	+30 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

enne (OOO)

6 years, 3 months ago (2014-09-02 23:47:53 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as ed16153 (presubmit successful).

Expand Messages | Collapse Messages