Issue 534813002: Remove some rtc hacks in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 534813002: Remove some rtc hacks in the GN build. (Closed)

Created:
6 years, 3 months ago by brettw

Modified:
6 years, 3 months ago

Reviewers:
kjellander_chromium

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, chromoting-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Remove some rtc hacks in the GN build. Remove explicitly depending on a webrtc config now that it is correctly exported from webrtc. R=kjellander@chromium.org Committed: https://crrev.com/339a17f9efb734ed53112eca9bba0646d3cd1223 Cr-Commit-Position: refs/heads/master@{#294424}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -14 lines)			Patch
M	chrome/browser/extensions/BUILD.gn	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	remoting/base/BUILD.gn	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	third_party/libjingle/BUILD.gn	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 5 (1 generated)

brettw

This would go in after https://webrtc-codereview.appspot.com/14309004/ is rolled into Chrome.

6 years, 3 months ago (2014-09-02 23:39:29 UTC) #2

brettw

Committed patchset #2 (id:20001) to pending queue manually as bfbc395.

6 years, 3 months ago (2014-09-11 18:15:42 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-11 18:43:16 UTC) #5

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/339a17f9efb734ed53112eca9bba0646d3cd1223
Cr-Commit-Position: refs/heads/master@{#294424}