Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 534793002: Makes matching of build files work when absolute (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Makes matching of build files work when absolute Matching wasn't working if paths supplied were absolute. gyp_chromium triggers absolute paths, so picking up modified gyp/gypi files wasn't working when analyzer run from chrome. BUG=109173 TEST=none R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1972

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M pylib/gyp/generator/analyzer.py View 4 chunks +16 lines, -11 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
sky
6 years, 3 months ago (2014-09-02 22:00:02 UTC) #2
scottmg
lgtm https://codereview.chromium.org/534793002/diff/1/pylib/gyp/generator/analyzer.py File pylib/gyp/generator/analyzer.py (right): https://codereview.chromium.org/534793002/diff/1/pylib/gyp/generator/analyzer.py#newcode135 pylib/gyp/generator/analyzer.py:135: if path.startswith(toplevel_dir + '/'): will there be any ...
6 years, 3 months ago (2014-09-02 22:06:45 UTC) #3
sky
https://codereview.chromium.org/534793002/diff/1/pylib/gyp/generator/analyzer.py File pylib/gyp/generator/analyzer.py (right): https://codereview.chromium.org/534793002/diff/1/pylib/gyp/generator/analyzer.py#newcode135 pylib/gyp/generator/analyzer.py:135: if path.startswith(toplevel_dir + '/'): On 2014/09/02 22:06:45, scottmg wrote: ...
6 years, 3 months ago (2014-09-02 22:11:30 UTC) #4
sky
6 years, 3 months ago (2014-09-02 22:12:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r1972 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698