Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 534743002: ScopedPtrVector change back const_iterator typedef (Closed)

Created:
6 years, 3 months ago by weiliangc
Modified:
6 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org, Ian Vollick, jbauman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ScopedPtrVector change back const_iterator typedef Calling begin() const and end() const function in ScopedPtrVector has compiler error with const_iterator. Change back from const T* to T*. Also since cpplint complains has to change a reference to pointer. Committed: https://crrev.com/c1878c6c7218b3e76878cce50589f623802c7685 Cr-Commit-Position: refs/heads/master@{#293014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M cc/base/scoped_ptr_vector.h View 2 chunks +4 lines, -6 lines 0 comments Download
M cc/base/scoped_ptr_vector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
weiliangc
Change typedef of const_iterator in ScopedPtrVector from vector<const T*> back to vector<T*>.
6 years, 3 months ago (2014-09-02 20:21:07 UTC) #2
danakj
LGTM
6 years, 3 months ago (2014-09-02 20:48:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weiliangc@chromium.org/534743002/1
6 years, 3 months ago (2014-09-02 20:49:33 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-09-02 21:47:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6a44ec733d0f0673f2b04698539537bfe5afce4c
6 years, 3 months ago (2014-09-02 22:44:43 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:21:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1878c6c7218b3e76878cce50589f623802c7685
Cr-Commit-Position: refs/heads/master@{#293014}

Powered by Google App Engine
This is Rietveld 408576698