Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Issue 534713002: [Merge] [Win, Linux] Always display the avatar button text at the same size. (Closed)

Created:
6 years, 3 months ago by noms (inactive)
Modified:
6 years, 3 months ago
Reviewers:
noms (inactive)
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@2125
Project:
chromium
Visibility:
Public.

Description

[Merge] [Win, Linux] Always display the avatar button text at the same size. The problem is that some locales (Hindi) or platforms (Linux) have a bigger base font size for the default font (crbug.com/405994). If this is the case, we should decrease the font size to the one we expect, so that the font fits in the button correctly. Just adjusting the baseline is not always enough, as the new avatar button has a fixed size, and the text might not fit correctly regardless of the baseline adjustments. Screenshots: https://drive.google.com/folderview?id=0B1B1Up4p2NRMRHc5WTBxZWNrRm8&usp=sharing BUG=403466 TBR=noms@chromium.org TEST=Start Chrome with --enable-new-avatar-menu on Linux, or with --enable-new-avatar-menu and --lang-hi on Windows. The avatar button text should fit nicely in the button. Review URL: https://codereview.chromium.org/470053004 Cr-Commit-Position: refs/heads/master@{#292715} (cherry picked from commit 899ae44e331661f709f463d6861a1dbceb9194f2) Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/f8e6698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -50 lines) Patch
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 2 chunks +3 lines, -50 lines 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/gfx/font_list.h View 1 chunk +25 lines, -0 lines 0 comments Download
M ui/gfx/font_list.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M ui/gfx/font_list_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
noms (inactive)
6 years, 3 months ago (2014-09-02 19:04:36 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as f8e6698 (presubmit
successful).

Powered by Google App Engine
This is Rietveld 408576698