Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 534703004: Revert of Add support for Java nano protocol buffers for Android. (Closed)

Created:
6 years, 3 months ago by nyquist
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Colin Meek
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for Java nano protocol buffers for Android. (patchset #4 id:60001 of https://codereview.chromium.org/511283003/) Reason for revert: Breaks some workflows and also should get new quota. Original issue's description: > Add support for Java nano protocol buffers for Android. > > This CL adds a new dependency on the protocol buffer compiler > from the android source tree, since this compiler supports > generating Java files using the nano runtime. > > The initial version of this dependency is 2.2.0a, but checked > out as what the Android 4.4.4 Release 2.0.1 tag points to. > > This CL adds a new protoc binary (for compiling protos) that supports > this, and also adds a Java library with the runtime. > > To simplify use of this, it also updates build/protoc_java.gypi to > support generating nano protos by specifying an optional > proto_runtime argument. The argument defaults to 'lite' which does > the same thing as before this change, and setting it to 'nano' > generates the new style Java files. > > The plan is to quickly deprecate the 'lite' runtime for Java, since > it is too big and uses too many methods. > > BUG=377891 > > Committed: https://chromium.googlesource.com/chromium/src/+/d8ae0a79834531e41912de44b9e212ffa7eb2785 TBR=cjhopman@chromium.org,darin@chromium.org NOTREECHECKS=true NOTRY=true BUG=377891 Committed: https://crrev.com/e3f2241bc1235a54254f165db374f6013e037233 Cr-Commit-Position: refs/heads/master@{#293028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -220 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M build/protoc_java.gypi View 3 chunks +5 lines, -25 lines 0 comments Download
M build/protoc_java.py View 3 chunks +11 lines, -23 lines 0 comments Download
D third_party/android_protobuf/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/android_protobuf/README.chromium View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/android_protobuf/android_protobuf.gyp View 1 chunk +0 lines, -137 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nyquist
Created Revert of Add support for Java nano protocol buffers for Android.
6 years, 3 months ago (2014-09-02 22:15:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/534703004/1
6 years, 3 months ago (2014-09-02 22:16:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2acece2650cb79e2c781bbbbf8f8a3598c559b3e
6 years, 3 months ago (2014-09-03 00:09:31 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:22:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3f2241bc1235a54254f165db374f6013e037233
Cr-Commit-Position: refs/heads/master@{#293028}

Powered by Google App Engine
This is Rietveld 408576698