Add CloseMultipleNowOrOnExec()

Add CloseMultipleNowOrOnExec().

R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/d492df404c100c5792f441064dfcbbfd189a703c

[Mark Mentovai, 2014-09-02 19:48:23]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Mark Mentovai, 2014-09-02 19:49:32]

This is just about impossible to test on its own, without fork-and-exec. Rather
than write redundant test code to do that, the plan here is to make sure that
FDs are closed properly in an exec()ed child in the test for MultiprocessExec,
coming after this lands.

[Robert Sesek, 2014-09-02 20:04:29]

LGTM

https://codereview.chromium.org/534703003/diff/1/util/test/posix/close_multip...
File util/test/posix/close_multiple.cc (right):

https://codereview.chromium.org/534703003/diff/1/util/test/posix/close_multip...
util/test/posix/close_multiple.cc:34: // logging code that is not expected to
execute under normal circumstances is
I think this is a bit questionable, but I won't press it.

[Mark Mentovai, 2014-09-02 20:19:12]

You’re right, but it’s test-only for now and I don’t have RAW_LOG in here (yet?)

Kinda casts doubt on all of the other fork-non-exec tests too, doesn’t it? Once
we can do the fork-and-exec tests, I should be able to get rid of all of those.

[Mark Mentovai, 2014-09-02 20:21:50]

Committed patchset #1 (id:1) manually as d492df4 (presubmit successful).