Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 534703002: Require 'CHROME_HEADLESS' to use 'git-number'. (Closed)

Created:
6 years, 3 months ago by dnj
Modified:
6 years, 3 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Project:
tools
Visibility:
Public.

Description

Require 'CHROME_HEADLESS' to use 'git-number'. Updated 'git-number' to produce an error message if it's run without the CHROME_HEADLESS (bot) environment variable. This is intended to alert developers who may be incorrectly using this tool to get positioning information instead of the commit position. BUG=409917 TEST=local - Ran with and without 'CHROME_HEADLESS'; observed the error message in the 'without' case. R=iannucci@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291773

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated environment check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M git_number.py View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
dnj
6 years, 3 months ago (2014-09-02 18:29:11 UTC) #1
dnj
Poke, let's close this :)
6 years, 3 months ago (2014-09-02 20:08:53 UTC) #2
iannucci
lgtm https://codereview.chromium.org/534703002/diff/1/git_number.py File git_number.py (right): https://codereview.chromium.org/534703002/diff/1/git_number.py#newcode256 git_number.py:256: if not os.getenv('CHROME_HEADLESS'): if os.getenv('CHROME_HEADLESS') != '1':
6 years, 3 months ago (2014-09-02 20:39:16 UTC) #3
dnj
https://codereview.chromium.org/534703002/diff/1/git_number.py File git_number.py (right): https://codereview.chromium.org/534703002/diff/1/git_number.py#newcode256 git_number.py:256: if not os.getenv('CHROME_HEADLESS'): On 2014/09/02 20:39:16, iannucci wrote: > ...
6 years, 3 months ago (2014-09-02 20:46:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnj@chromium.org/534703002/20001
6 years, 3 months ago (2014-09-02 20:48:11 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-02 20:50:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 291773

Powered by Google App Engine
This is Rietveld 408576698