Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 534683002: Revert of Add Keys() function to ServiceWorkerCache. (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
Reviewers:
michaeln, jkarlin, gavinp
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cache_patch
Project:
chromium
Visibility:
Public.

Description

Revert of Add Keys() function to ServiceWorkerCache. (patchset #13 id:280001 of https://codereview.chromium.org/477973002/) Reason for revert: Failing on content_unittests EmptyKeys_1 TwoKeys_1 TwoKeysThenOne_1 on Linux ASAN LSAN Original issue's description: > Add Keys() function to ServiceWorkerCache. > > Other changes: > * Introduced a ReadHeaders helper function which reads headers from a cache entry into a protobuf. This is used by Match() and Keys(). > > > BUG=392621 > > Committed: https://chromium.googlesource.com/chromium/src/+/02812f0a3edcacca1f7e05ea0a47cb3d8c6025e1 TBR=michaeln@chromium.org,gavinp@chromium.org,jkarlin@chromium.org NOTREECHECKS=true NOTRY=true BUG=392621 Committed: https://crrev.com/01bc0b71ce5b347c646cc08309ab7bc08fb966cb Cr-Commit-Position: refs/heads/master@{#292970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -332 lines) Patch
M content/browser/service_worker/service_worker_cache.h View 4 chunks +0 lines, -23 lines 0 comments Download
M content/browser/service_worker/service_worker_cache.cc View 11 chunks +38 lines, -211 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_unittest.cc View 6 chunks +22 lines, -98 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
Created Revert of Add Keys() function to ServiceWorkerCache.
6 years, 3 months ago (2014-09-02 18:18:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/534683002/1
6 years, 3 months ago (2014-09-02 18:20:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 597fcff6df18a7e61a8d8d94ead1233b001b6c4e
6 years, 3 months ago (2014-09-02 18:59:41 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:19:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01bc0b71ce5b347c646cc08309ab7bc08fb966cb
Cr-Commit-Position: refs/heads/master@{#292970}

Powered by Google App Engine
This is Rietveld 408576698