Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 534603002: android_webview: stop using system expat. (Closed)

Created:
6 years, 3 months ago by Torne
Modified:
6 years, 3 months ago
Reviewers:
benm (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

android_webview: stop using system expat. To support unbundled updates we need to stop depending on system libraries. Disable using the system version of libexpat and instead link Chromium's copy, and stop removing the expat sources from the checkout. This increases binary size by ~64KB. Also remove an obsolete comment about using the system version of sqlite; this was never implemented and now will not be. BUG=409851 Committed: https://crrev.com/eac62b75ce57c1689a48fadd4229c1346509a170 Cr-Commit-Position: refs/heads/master@{#293115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M android_webview/tools/known_issues.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Torne
6 years, 3 months ago (2014-09-02 14:46:46 UTC) #2
benm (inactive)
lgtm
6 years, 3 months ago (2014-09-02 17:57:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/534603002/1
6 years, 3 months ago (2014-09-03 09:09:39 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-03 09:57:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5e200fa00f59d0e40e20151168f8a51a16a0cce2
6 years, 3 months ago (2014-09-03 10:56:55 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:25:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eac62b75ce57c1689a48fadd4229c1346509a170
Cr-Commit-Position: refs/heads/master@{#293115}

Powered by Google App Engine
This is Rietveld 408576698