Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 534573002: Reland "Make FrameStates recursive (to be used for inlining).". (Closed)

Created:
6 years, 3 months ago by sigurds
Modified:
6 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland "Make FrameStates recursive (to be used for inlining).". Reland fixes: - Verifier is now aware of sentinel value for FrameState chains. R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23662

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Add comment. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -54 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/code-generator.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 2 chunks +27 lines, -11 lines 0 comments Download
M src/compiler/graph-builder.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction.h View 1 chunk +27 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 2 chunks +16 lines, -6 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/instruction-selector-unittest.cc View 1 2 3 3 chunks +97 lines, -5 lines 0 comments Download
M src/compiler/node.h View 1 chunk +8 lines, -1 line 0 comments Download
M src/compiler/operator-properties-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 2 3 4 chunks +13 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sigurds
6 years, 3 months ago (2014-09-02 13:30:43 UTC) #1
Jarin
lgtm
6 years, 3 months ago (2014-09-02 15:31:44 UTC) #2
sigurds
6 years, 3 months ago (2014-09-03 14:10:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as 23662 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698