Clean up ManagePasswordsBubbleView and ManagePasswordItemView.

Clean up ManagePasswordsBubbleView and ManagePasswordItemView.

Removed unnecessary includes, reorder the methods, moved private classes to .cc.

Committed: https://crrev.com/bf8d318639312cc80214463b7b5195133327ac12
Cr-Commit-Position: refs/heads/master@{#292942}

[vasilii, 2014-09-02 11:43:32]

vasilii@chromium.org changed reviewers:
+ vabr@chromium.org

[vasilii, 2014-09-02 11:43:33]

Hi Vaclav,

please review.

[vabr (Chromium), 2014-09-02 13:29:28]

Thanks for the clean-up Vasilii, much appreciated!

This reminds me: you should really become an OWNER of both the sync-related and
also the bubble-related code in password manager, at the very least (I would
also support you becoming the OWNER of all password manager code). Let me know
if you decide to do it, I'll happily approve a CL for that.

Cheers,
Vaclav

https://codereview.chromium.org/534543002/diff/1/chrome/browser/ui/views/pass...
File chrome/browser/ui/views/passwords/manage_password_item_view.cc (right):

https://codereview.chromium.org/534543002/diff/1/chrome/browser/ui/views/pass...
chrome/browser/ui/views/passwords/manage_password_item_view.cc:101: virtual
~PendingView() {}
Please do not inline the destructors in the classes newly added to this .cc, see
http://dev.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-in....
The only destructors fine to inline are in classes in which all (incl.
inherited) data members are POD (plain old data, like int, etc.).

https://codereview.chromium.org/534543002/diff/1/chrome/browser/ui/views/pass...
File chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc (left):

https://codereview.chromium.org/534543002/diff/1/chrome/browser/ui/views/pass...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc:212:
ManagePasswordsBubbleView::PendingView::~PendingView() {
Any particular reason for dropping the destructors here?

[vabr (Chromium), 2014-09-02 13:29:41]

LGTM, of course :)

[vabr (Chromium), 2014-09-02 13:30:42]

On 2014/09/02 13:29:41, vabr (Chromium) wrote:
> LGTM, of course :)

I should learn to write reviews...
Please make sure to read both my previous e-mails. :)

Cheers,
Vaclav

[vasilii, 2014-09-02 15:33:33]

https://codereview.chromium.org/534543002/diff/1/chrome/browser/ui/views/pass...
File chrome/browser/ui/views/passwords/manage_password_item_view.cc (right):

https://codereview.chromium.org/534543002/diff/1/chrome/browser/ui/views/pass...
chrome/browser/ui/views/passwords/manage_password_item_view.cc:101: virtual
~PendingView() {}
On 2014/09/02 13:29:28, vabr (Chromium) wrote:
> Please do not inline the destructors in the classes newly added to this .cc,
see
>
http://dev.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-in....
> The only destructors fine to inline are in classes in which all (incl.
> inherited) data members are POD (plain old data, like int, etc.).

Done.

https://codereview.chromium.org/534543002/diff/1/chrome/browser/ui/views/pass...
File chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc (left):

https://codereview.chromium.org/534543002/diff/1/chrome/browser/ui/views/pass...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc:212:
ManagePasswordsBubbleView::PendingView::~PendingView() {
On 2014/09/02 13:29:28, vabr (Chromium) wrote:
> Any particular reason for dropping the destructors here?

Not really. Reverted.

[vasilii, 2014-09-02 15:35:15]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2014-09-02 15:38:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vasilii@chromium.org/534543002/20001

[commit-bot: I haz the power, 2014-09-02 16:34:11]

Committed patchset #2 (id:20001) as 30b080a263afba0b8221eb47ee55676964b47ea4

[commit-bot: I haz the power, 2014-09-10 03:18:59]

Patchset 2 (id:??) landed as
https://crrev.com/bf8d318639312cc80214463b7b5195133327ac12
Cr-Commit-Position: refs/heads/master@{#292942}