Adding more detailed UMA histogram for detection of output audio glitches

Adding more detailed UMA histogram for detection of output audio glitches.

BUG=NONE
TEST=Manual test of WebRTC clients under heavy load.
R=asvitkine@chromium.org, tommi@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/03573630c9619e21c299eef4fd41c8704421d2a6

[henrika (OOO until Aug 14), 2014-09-02 10:55:06]

henrika@chromium.org changed reviewers:
+ tommi@chromium.org

[henrika (OOO until Aug 14), 2014-09-02 10:56:06]

As discussed Tommi. Will add XML-part when this part is OK.

Example (no glitches detected):

Histogram: Media.AudioRendererAudioGlitches recorded 4 samples, average = 0.0
(flags = 0x1)
0  ------------------------------------------------------------------------O (4
= 100.0%)
1  ...

[henrika (OOO until Aug 14), 2014-09-02 11:06:00]

Example where only one miss is detected. New stat shows it but old stat says
"0%".

Histogram: Media.AudioRendererAudioGlitches recorded 1 samples, average = 1.0
(flags = 0x1)
0  O                                                                         (0
= 0.0%)
1  ------------------------------------------------------------------------O (1
= 100.0%) {0.0%}
2  O                                                                         (0
= 0.0%) {100.0%}


Histogram: Media.AudioRendererMissedDeadline recorded 1 samples, average = 0.0
(flags = 0x1)
0  ------------------------------------------------------------------------O (1
= 100.0%)
1  ...

[tommi (sloooow) - chröme, 2014-09-02 11:08:45]

lgtm

https://codereview.chromium.org/534533002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/media/audio_sync_reader.cc (right):

https://codereview.chromium.org/534533002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/media/audio_sync_reader.cc:76: std::ostringstream
oss;
nit: use StringPrintf since the style guide allows streams only for logging and
I don't think the NativeLog qualifies (as per a similar discussion in a
different review thread).

[henrika (OOO until Aug 14), 2014-09-02 11:28:46]

https://codereview.chromium.org/534533002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/media/audio_sync_reader.cc (right):

https://codereview.chromium.org/534533002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/media/audio_sync_reader.cc:76: std::ostringstream
oss;
On 2014/09/02 11:08:45, tommi wrote:
> nit: use StringPrintf since the style guide allows streams only for logging
and
> I don't think the NativeLog qualifies (as per a similar discussion in a
> different review thread).

Done.

[henrika (OOO until Aug 14), 2014-09-02 12:17:36]

henrika@chromium.org changed reviewers:
+ asvitkine@chromium.org

[henrika (OOO until Aug 14), 2014-09-02 12:18:47]

Alexei@: asking for your OK on the XML part. Thanks!

[Alexei Svitkine (slow), 2014-09-02 14:46:45]

https://codereview.chromium.org/534533002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/media/audio_sync_reader.cc (right):

https://codereview.chromium.org/534533002/diff/40001/content/browser/renderer...
content/browser/renderer_host/media/audio_sync_reader.cc:36: }
Nit: add // namespace

https://codereview.chromium.org/534533002/diff/40001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/534533002/diff/40001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:11061: +  <summary>Captures if
render-side audio glitches are detected or not.</summary>
Please document when this is logged. Periodically? When something happens?

[henrika (OOO until Aug 14), 2014-09-02 15:10:11]

Thanks Alexei. PTAL ;-)

https://codereview.chromium.org/534533002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/media/audio_sync_reader.cc (right):

https://codereview.chromium.org/534533002/diff/40001/content/browser/renderer...
content/browser/renderer_host/media/audio_sync_reader.cc:36: }
On 2014/09/02 14:46:45, Alexei Svitkine wrote:
> Nit: add // namespace

Done.

[Alexei Svitkine (slow), 2014-09-02 15:20:11]

lgtm

https://codereview.chromium.org/534533002/diff/60001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/534533002/diff/60001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:11063: +    when a low-latency output
audio stream is destructed.
Nit: I'd reword this to be a little bit more clear -> "Sampled when a
low-latency output audio stream is destructed." (Since "once" can be confusing.)

[henrika (OOO until Aug 14), 2014-09-02 15:23:01]

Thanks. Fixed ;-)

[henrika (OOO until Aug 14), 2014-09-02 15:23:11]

The CQ bit was checked by henrika@chromium.org

[commit-bot: I haz the power, 2014-09-02 15:27:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/henrika@chromium.org/534533002/80001

[commit-bot: I haz the power, 2014-09-02 16:29:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[commit-bot: I haz the power, 2014-09-02 16:38:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-02 16:38:35]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[henrika (OOO until Aug 14), 2014-09-03 08:53:30]

Committed patchset #5 (id:80001) manually as 0357363 (presubmit successful).

[jam, 2014-09-04 02:59:13]

On 2014/09/03 08:53:30, henrika wrote:
> Committed patchset #5 (id:80001) manually as 0357363 (presubmit successful).

why did you land this manually? the trybots showed the builds were red, and when
this landed it caused the tree to break and also other tryjobs that the CQ was
sending out.

[henrika (OOO until Aug 14), 2014-09-04 07:48:03]

I did a mistake. Had other try-jobs running for other CL and they failed for the
same bot (but not due to my changes). I read the results here with a bias "yet
another flake" and missed/ignored that it was clearly my fault in this case. In
short: I was dead wrong and apologize. Won't happen again.

[commit-bot: I haz the power, 2014-09-10 03:24:27]

Patchset 5 (id:??) landed as
https://crrev.com/03573630c9619e21c299eef4fd41c8704421d2a6
Cr-Commit-Position: refs/heads/master@{#293099}