Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 534493002: Audio Player: Cancel scheduled advance if the track has been changed (Closed)

Created:
6 years, 3 months ago by yoshiki
Modified:
6 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Audio Player: Cancel scheduled advance if the track has been changed BUG=348487 TEST=manual Committed: https://crrev.com/8b1ace1021431de695a50a52537a64922b007620 Cr-Commit-Position: refs/heads/master@{#292910}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : Fix the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M ui/file_manager/file_manager/audio_player/elements/audio_player.js View 1 2 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
fukino
On 2014/09/02 06:43:56, yoshiki wrote: > mailto:yoshiki@chromium.org changed reviewers: > + mailto:fukino@chromium.org The bug id ...
6 years, 3 months ago (2014-09-02 06:59:43 UTC) #2
fukino
Ah, I found the issue id. It must be 348487. (Please update the descripotion). Regarding ...
6 years, 3 months ago (2014-09-02 07:33:08 UTC) #3
yoshiki
Thanks! Fixed and going to commit. https://codereview.chromium.org/534493002/diff/20001/ui/file_manager/file_manager/audio_player/elements/audio_player.js File ui/file_manager/file_manager/audio_player/elements/audio_player.js (right): https://codereview.chromium.org/534493002/diff/20001/ui/file_manager/file_manager/audio_player/elements/audio_player.js#newcode274 ui/file_manager/file_manager/audio_player/elements/audio_player.js:274: // If the ...
6 years, 3 months ago (2014-09-02 10:56:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/534493002/40001
6 years, 3 months ago (2014-09-02 10:56:26 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as bd3b38d3cfa1ccc19e918eedd1703182827b7ce2
6 years, 3 months ago (2014-09-02 11:52:19 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:18:02 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8b1ace1021431de695a50a52537a64922b007620
Cr-Commit-Position: refs/heads/master@{#292910}

Powered by Google App Engine
This is Rietveld 408576698